Problem/Motivation

From https://www.drupal.org/project/gdwc/issues/3273194

The Drupal State upgrade here is a breaking change, and it broke something :) I believe the breaking change was this issue: https://www.drupal.org/project/drupal_state/issues/3278449 which will require changes to how the json:api include parameters are passed. Likely to need changes in some combination of the provider and the store controller.

Easiest change here would probably be to revert the Drupal State upgrade, which would allow us to merge the rest of the updates here and handle the Drupal State upgrade and necessary refactoring in another issue.

This is that other issue.

Steps to reproduce

Upgrade Drupal State to latest release, see that gdwc-provider story won't load and throws console errors.

Proposed resolution

To resolve this breaking change, the include prop on gdwc-provider should be changed to params. This will actually result in additional functionality for the component - previously it only supported include parameters, but this change will allow any json:api params to be used.

Remaining tasks

* Upgrade Drupal State to latest.
* Resolve breaking changes in gdwc-provider
* Update any existing stories that use gdwc-provider

API changes

gdwc-provider: include prop will be removed in favor of a params prop.

Issue fork gdwc-3299099

Command icon Show commands

Start within a Git clone of the project using the version control instructions.

Or, if you do not have SSH keys set up on git.drupalcode.org:

Comments

brianperry created an issue. See original summary.

  • brianperry committed ed18d17 on 1.0.x
    Issue #3299099 by brianperry: Upgrade Drupal State Dependency to 3.0.0...
brianperry’s picture

Assigned: brianperry » Unassigned
Status: Active » Fixed

Upgraded to Drupal State 4.1.0 and addressed breaking changes. This had a substantial impact on the bundle size.

Before:

dist/style.css 17.15 KiB / gzip: 4.07 KiB
dist/components.js 515.74 KiB / gzip: 121.10 KiB
dist/components.umd.cjs 364.37 KiB / gzip: 105.66 KiB

After:

dist/style.css 17.15 KiB / gzip: 4.07 KiB
dist/components.js 183.40 KiB / gzip: 45.45 KiB
dist/components.umd.cjs 142.13 KiB / gzip: 40.88 KiB

This has been merged into 1.0.x, but will hold off on releasing to npm until this is included in https://www.drupal.org/project/gdwc/issues/3299644 so this can be combined into a single breaking change.

Status: Fixed » Closed (fixed)

Automatically closed - issue fixed for 2 weeks with no activity.