Problem/Motivation

Apply recent dependency updates.

Steps to reproduce

Proposed resolution

Remaining tasks

User interface changes

API changes

Data model changes

Issue fork gdwc-3273194

Command icon Show commands

Start within a Git clone of the project using the version control instructions.

Or, if you do not have SSH keys set up on git.drupalcode.org:

About issue forks

Comments

brianperry created an issue. See original summary.

finnsky made their first commit to this issue’s fork.

finnsky opened merge request !43

finnsky’s picture

finnsky commented
Status: Active » Needs review

1. Updated packages to recent versions.
2. Fixed version in package.lock
3. Tested all scripts. Word as designed.
4. Fixed formatting in stories/gdwc-card/gdwc-card.stories.js

Audit still shows errors with vulnerable versions of trim
but they should gone after updates in storybook core
https://github.com/storybookjs/storybook/pull/18157

andypost’s picture

andypost
he/him
Primary language Russian
commented
Status: Needs review » Reviewed & tested by the community

LGTM

brianperry’s picture

brianperry
he/him
commented
Status: Reviewed & tested by the community » Needs work

@finnsky The Drupal State upgrade here is a breaking change, and it broke something :) I believe the breaking change was this issue: https://www.drupal.org/project/drupal_state/issues/3278449 which will require changes to how the json:api include parameters are passed. Likely to need changes in some combination of the provider and the store controller.

Easiest change here would probably be to revert the Drupal State upgrade, which would allow us to merge the rest of the updates here and handle the Drupal State upgrade and necessary refactoring in another issue.

finnsky’s picture

finnsky commented
Status: Needs work » Needs review

Reverted drupal-state update

brianperry opened merge request !48

  • brianperry committed 6d2d308 on 1.0.x 
    Issue #3273194 by finnsky, brianperry, andypost: NPM Audit
brianperry’s picture

brianperry
he/him
commented
Status: Needs review » Fixed

Merged. Thanks for the help @finnsky and @andypost

brianperry closed merge request !43

Status: Fixed » Closed (fixed)

Automatically closed - issue fixed for 2 weeks with no activity.