When you select a different color scheme the changes are shown in the preview. When you then save the changes, they are not shown on the website.

There are a few small errors in the color/color.inc file. I am testing some fixes for that now. I'll post a patch when I think I found the solution.

CommentFileSizeAuthor
#10 changes_in_color_scheme-2848972-10.patch8.33 KBalex_optim
#5 changes_in_color_scheme-2848972-5.patch369 bytesalex_optim
Support from Acquia helps fund testing for Drupal Acquia logo

Comments

jos_s created an issue. See original summary.

alex_optim’s picture

alex_optim
Location 🇺🇦 Rivne
CreditAttribution: alex_optim commented
Assigned: Unassigned » alex_optim
jos_s’s picture

jos_s CreditAttribution: jos_s commented
Title: changes in color schame not shown » changes in color scheme not shown
jos_s’s picture

jos_s CreditAttribution: jos_s commented

Hi alex_optim,

I found that when in color.inc you change

  'css' => array(
    'style.css',
  ),

into

  'css' => array(
    'css/colors.css',
    'css/style.css',
    'css/layout.css',
  ),

Also there the color codes that need to be changed in the color.css files are not all the same as in the default scheme as defined in color.inc. They have to be if they need be changed.

After these changes you can select a new predefined color scheme, but it is still not possible to add a custom color scheme. This is not saved. I have not found out how this is supposed to work.

alex_optim’s picture

alex_optim
Location 🇺🇦 Rivne
CreditAttribution: alex_optim commented
FileSize
changes_in_color_scheme-2848972-5.patch369 bytes

Hi jos_s,
thank you for your help. I have created patch, but there is a problem with logo.
Theme don't create logo.svg file.

jos_s’s picture

jos_s CreditAttribution: jos_s commented

Hi alex_optim,
The file logo.svg that is included in the theme is actually a .png file. When you rename it to logo.png the new logo file is created with the correct color.

alex_optim’s picture

alex_optim
Location 🇺🇦 Rivne
CreditAttribution: alex_optim commented

In my opinion, it would be better if the pic would generate in .svg format or just using the pic (which is using the main colour scheme).

alex_optim’s picture

alex_optim
Location 🇺🇦 Rivne
CreditAttribution: alex_optim commented
Assigned: alex_optim » Unassigned
jos_s’s picture

jos_s CreditAttribution: jos_s commented

I have had another look at the logo.svg file. It is a real SVG after all, so my first presumption was wrong.

If the file color.inc, logo.svg is not mentioned, however. You should change logo.png to logo.svg. Then the logo is also generated with the correct colors.

alex_optim’s picture

alex_optim
Location 🇺🇦 Rivne
CreditAttribution: alex_optim commented
Status: Active » Needs review
FileSize
changes_in_color_scheme-2848972-10.patch8.33 KB

I replaced logo.svg file and create patch.

  • joachim committed c0ef38a on 8.x-2.x authored by alex_optim 
    Issue #2848972 by alex_optim, jos_s: Fixed changes in color scheme not...
joachim’s picture

joachim CreditAttribution: joachim as a volunteer commented
Status: Needs review » Fixed

Confirming the patch fixes the problem.

Committed. Thanks!

joachim’s picture

joachim CreditAttribution: joachim as a volunteer commented
Version: 8.x-2.x-dev » 8.x-1.x-dev
Status: Fixed » Patch (to be ported)

Probably needs a backport.