FILE: C:\xampp\htdocs\drupal95\web\modules\contrib\gantt\gantt.theme.inc
------------------------------------------------------------------------
FOUND 0 ERRORS AND 4 WARNINGS AFFECTING 4 LINES
------------------------------------------------------------------------
22 | WARNING | Unused variable $baseTable.
28 | WARNING | Unused variable $colors.
67 | WARNING | Unused variable $columns.
97 | WARNING | Unused variable $dateSettings.
------------------------------------------------------------------------
| Comment | File | Size | Author |
|---|---|---|---|
| #5 | phpcs_3310629-5.txt | 3.49 KB | gabrieldv |
| #4 | 3310629-4.patch | 555 bytes | gabrieldv |
| #2 | unused-variables-3310629-2.patch | 2.15 KB | akshay.kelotra |
Comments
Comment #2
akshay.kelotra commentedI have fixed this issue and providing a patch.
Comment #3
gabrieldv commentedThanks for the changes @akshay.kelotra, I'll review it :)
Comment #4
gabrieldv commentedThe last patch was outdated so i sent a patch that fix the PHPCS warning inside the issue scope file.
Comment #5
gabrieldv commentedAlso, the PHPCS returned me more errors, but i thought it wasn't in this issue scope so i added in a file showing every error i found.
Command: phpcs --standard=Drupal,DrupalPractice --extensions=php,module,inc,install,test,profile,theme,css,info,txt,md,yml
Comment #6
lazzyvn commentedjust run phpcs --standard=Drupal it will work :)
Comment #7
gersonjlHi, I'll review this
Comment #8
gersonjlWarnings reported by @akshay.kelotra are gone with @gabrieldv patch.
Comment #9
lazzyvn commented