PHP Notices when creating node [#1319268]

When creating a node I was running into PHP notices on lines 40 and 45 of theme/theme.inc:

Undefined index: uri in template_preprocess_galleria_container()

A patch is provided with some defensive code if there is no uri field available. This seems to do the trick.

Comment	File	Size	Author
	galleria_fix_missing_uri.patch	607 bytes	murrayw

Support from Acquia helps fund testing for Drupal Acquia logo

Comments

Comment #1

kroimon CreditAttribution: kroimon commented 24 October 2011 at 08:20

Thanks for the patch!

How exactly did you run into these notices? I tried creating a new node with a Galleria-styled image field, but never got any errors...

Comment #2

miro_dietiker

Switzerland

CreditAttribution: miro_dietiker commented 24 October 2011 at 08:32

I see 2 issues to check
- adding a field after already nodes exist, displaying those nodes
- adding a non-required image field, creating a node without uploading an image, displaying it

Comment #3

kroimon CreditAttribution: kroimon commented 24 October 2011 at 08:42

In both cases, the $items array should be empty, so the foreach loop should never run.
I asked how to reproduce the bug to see what elements in the items array have no uri field.

Comment #4

murrayw CreditAttribution: murrayw commented 10 November 2011 at 00:54

I never actually saw the error myself but it was reported by a user. The steps they took to generate it were:
- create a new galleria node
- upload multiple images
- click save

The user reported that only the first image was saved. Looks like there might have been some problem with saving the images leading to the image not having a full uri. So not sure how it happened but we did have images with no uri.