my understanding of bast practices is that all tables should have a primary key to make database queries run faster

CommentFileSizeAuthor
#13 ga_stats_7_2_beta1_primary_key_not_null_2701489-13.patch3.68 KBMike.Conley
#12 ga_stats_7_2_beta1_primary_key_not_null_2701489-12.patch3.68 KBMike.Conley
#11 ga_stats_7_2_beta1_primary_key_not_null_2701489-11.patch3.68 KBMike.Conley
#10 ga_stats_7_2_beta1_primary_key_not_null_2701489-10.patch5.1 KBMike.Conley
#9 ga_stats_7_2_beta1_primary_key_not_null_2701489_002.patch3.21 KBbrtamas
#8 ga_stats_7_2_beta1_primary_key_not_null_2701489_001.patch560 bytesbrtamas
#2 ga_stats_count_table-2701489-2.patch667 bytesjrglasgow
Support from Acquia helps fund testing for Drupal Acquia logo

Comments

jrglasgow created an issue. See original summary.

jrglasgow’s picture

jrglasgow CreditAttribution: jrglasgow commented
Status: Active » Needs review
FileSize
ga_stats_count_table-2701489-2.patch667 bytes

this patch makes the nid column a primary key

laxman.ghavte’s picture

laxman.ghavte CreditAttribution: laxman.ghavte as a volunteer and at Faichi Solutions Pvt Ltd commented
Status: Needs review » Reviewed & tested by the community

Hi jrglasgow,

Reviewed patch working fine.

  • marcelovani committed f588363 on 7.x-1.x authored by jrglasgow 
    Issue #2701489 by jrglasgow, laxman.ghavte: ga_stats_count table has no...
marcelovani’s picture

marcelovani
Primary language Portuguese, Brazil
Location London
CreditAttribution: marcelovani at Dennis commented
Status: Reviewed & tested by the community » Fixed

Status: Fixed » Closed (fixed)

Automatically closed - issue fixed for 2 weeks with no activity.

brtamas’s picture

brtamas CreditAttribution: brtamas at Integral Vision Ltd commented

I have got an error when I enable the module:

PDOException: SQLSTATE[42000]: Syntax error or access violation: 1171 All parts of a PRIMARY KEY must be NOT NULL;

I have created a patch to fix it.

brtamas’s picture

brtamas CreditAttribution: brtamas at Integral Vision Ltd commented
FileSize
ga_stats_7_2_beta1_primary_key_not_null_2701489_001.patch560 bytes
brtamas’s picture

brtamas CreditAttribution: brtamas at Integral Vision Ltd commented
FileSize
ga_stats_7_2_beta1_primary_key_not_null_2701489_002.patch3.21 KB
Mike.Conley’s picture

Mike.Conley CreditAttribution: Mike.Conley commented
FileSize
ga_stats_7_2_beta1_primary_key_not_null_2701489-10.patch5.1 KB

Refactoring brtamas' patch above -- the other columns in the primary key can't be NULL either.

Mike.Conley’s picture

Mike.Conley CreditAttribution: Mike.Conley commented
FileSize
ga_stats_7_2_beta1_primary_key_not_null_2701489-11.patch3.68 KB

Refactoring to apply cleanly.

Mike.Conley’s picture

Mike.Conley CreditAttribution: Mike.Conley commented
FileSize
ga_stats_7_2_beta1_primary_key_not_null_2701489-12.patch3.68 KB

Ugh. 3rd time is the charm.

Mike.Conley’s picture

Mike.Conley CreditAttribution: Mike.Conley commented
FileSize
ga_stats_7_2_beta1_primary_key_not_null_2701489-13.patch3.68 KB

Found a bug with a db_select query, needed to put the addField method on its own line.