TFA will be changing the way setup plugin ids work in a future version. We'll need to follow along with similar changes in this module.

See #2925066: Refactor implicitly named setup plugin id expectations to an annotation property

CommentFileSizeAuthor
#4 2938085-3.patch1.14 KBscreon
Support from Acquia helps fund testing for Drupal Acquia logo

Comments

daggerhart created an issue. See original summary.

daggerhart’s picture

daggerhart CreditAttribution: daggerhart commented
Title: Define setup_plugin_id annotation as the TFA api changes » Define setup plugin id annotation as the TFA module api changes
screon’s picture

screon CreditAttribution: screon commented
Assigned: Unassigned » screon
screon’s picture

screon CreditAttribution: screon at iO commented
Status: Active » Needs review
FileSize
2938085-3.patch1.14 KB

I created a patch which adds the new setupPluginId annotation to the two validation plugins. This was introduced in the patch at https://www.drupal.org/project/tfa/issues/2925066.

Waiting for the patch over at TFA to be implemented.

screon’s picture

screon CreditAttribution: screon at iO commented
Assigned: screon » Unassigned
jcnventura’s picture

jcnventura CreditAttribution: jcnventura at 1xINTERNET commented
Status: Needs review » Postponed

Setup plugins now start with 'ga_login_' prefix instead of 'tfa_'.

But most important, until #2925066: Refactor implicitly named setup plugin id expectations to an annotation property is committed, there's no point in creating patches here.

  • jcnventura authored 22c18ae on 8.x-1.x 
    Issue #2938085 by screon, jcnventura: Define setup plugin id annotation...
jcnventura’s picture

jcnventura CreditAttribution: jcnventura at 1xINTERNET commented
Status: Postponed » Fixed

Status: Fixed » Closed (fixed)

Automatically closed - issue fixed for 2 weeks with no activity.