Problem/Motivation

This is a follow-up to #2928722: Move the GA Validation plugins from the tfa module to ga_login module.

In that issue, two plugins were move to this module from the TFA module. When the plugins were moved, they kept their plugin IDs, "tfa_hotp" and "tfa_totp". The prefix "tfa" should be replaced by "ga_login".

Proposed resolution

Change the plugin IDs, update related config entities, and provide an update hook.

Remaining tasks

  • Change the plugin IDs
  • Update related config entities
  • Provide an update hook.

User interface changes

None

API changes

None

Data model changes

Some config entities provided by this module and the TFA module would have to be updated.

CommentFileSizeAuthor
#15 2932976-15.patch1.54 KBjcnventura
#10 2932976-10.patch9.59 KBjcnventura
#10 interdiff_9_10.txt2.67 KBjcnventura
#9 2932976-9.patch9.58 KBjcnventura
#9 interdiff_8_9.txt1.47 KBjcnventura
#8 interdiff-2932976-6-8.txt2.16 KBJeroenT
#8 2932976-8.patch10.29 KBJeroenT
#6 interdiff-2932976-3-6.txt1.65 KBJeroenT
#6 2932976-6.patch10.39 KBJeroenT
#3 2932976-3.patch8.24 KBJeroenT
#3 interdiff-2932976-2-3.txt525 bytesJeroenT
#2 2932976-2.patch8.25 KBJeroenT
Support from Acquia helps fund testing for Drupal Acquia logo

Comments

benjifisher created an issue. See original summary.

JeroenT’s picture

JeroenT
Primary language Dutch
Location 🇧🇪
CreditAttribution: JeroenT at iO commented
Status: Active » Needs review
FileSize
2932976-2.patch8.25 KB

The patch attached, updates the plugin ID's, config entities and there is an update hook provided.

JeroenT’s picture

JeroenT
Primary language Dutch
Location 🇧🇪
CreditAttribution: JeroenT at iO commented
FileSize
interdiff-2932976-2-3.txt525 bytes
2932976-3.patch8.24 KB

Removed some debugging code + comment fix.

The last submitted patch, 2: 2932976-2.patch, failed testing. View results
- codesniffer_fixes.patch Interdiff of automated coding standards fixes only.

Status: Needs review » Needs work

The last submitted patch, 3: 2932976-3.patch, failed testing. View results
- codesniffer_fixes.patch Interdiff of automated coding standards fixes only.

JeroenT’s picture

JeroenT
Primary language Dutch
Location 🇧🇪
CreditAttribution: JeroenT at iO commented
Status: Needs work » Needs review
FileSize
2932976-6.patch10.39 KB
interdiff-2932976-3-6.txt1.65 KB

Status: Needs review » Needs work

The last submitted patch, 6: 2932976-6.patch, failed testing. View results
- codesniffer_fixes.patch Interdiff of automated coding standards fixes only.

JeroenT’s picture

JeroenT
Primary language Dutch
Location 🇧🇪
CreditAttribution: JeroenT at iO commented
Status: Needs work » Needs review
FileSize
2932976-8.patch10.29 KB
interdiff-2932976-6-8.txt2.16 KB

Renamed the ga_login_recovery_code_setup back to tfa_login_recovery_setup.

jcnventura’s picture

jcnventura CreditAttribution: jcnventura at 1xINTERNET commented
FileSize
interdiff_8_9.txt1.47 KB
2932976-9.patch9.58 KB

Re-rolling.

jcnventura’s picture

jcnventura CreditAttribution: jcnventura at 1xINTERNET commented
FileSize
interdiff_9_10.txt2.67 KB
2932976-10.patch9.59 KB

hook must be 8002 now, and keep the configuration for all non ga_login tfa plugins.

Status: Needs review » Needs work

The last submitted patch, 10: 2932976-10.patch, failed testing. View results

  • jcnventura authored 9fed27c on 8.x-1.x 
    Issue #2932976 by JeroenT, jcnventura: Do not use tfa prefix for plugins...
jcnventura’s picture

jcnventura CreditAttribution: jcnventura at 1xINTERNET commented
Status: Needs work » Fixed
jcnventura’s picture

jcnventura CreditAttribution: jcnventura at 1xINTERNET commented
Status: Fixed » Needs work

Needs a further update hook to fix the plugins in users_data.

jcnventura’s picture

jcnventura CreditAttribution: jcnventura at 1xINTERNET commented
FileSize
2932976-15.patch1.54 KB

  • jcnventura authored 3b00031 on 8.x-1.x 
    Issue #2932976 by jcnventura: Rename plugin IDs in users_data.
jcnventura’s picture

jcnventura CreditAttribution: jcnventura at 1xINTERNET commented
Status: Needs work » Fixed

Status: Fixed » Closed (fixed)

Automatically closed - issue fixed for 2 weeks with no activity.