Recent versions of coder and php code sniffer scoff at some formatting bits in G2 7.x-1.x. Address them.

CommentFileSizeAuthor
#4 coding_standards_phpcs-1372746-4.patch0 bytesfgm
#1 coding_standards-1372746-1.patch189.43 KBfgm
Support from Acquia helps fund testing for Drupal Acquia logo

Comments

fgm’s picture

fgm
Primary language French
Location Paris, France
CreditAttribution: fgm commented
Title: Coder and phpcs cleanup » Coding standards cleanup
Status: Active » Needs review
FileSize
coding_standards-1372746-1.patch189.43 KB

Also, the new namespace coding standard uses uppercase initials on namespace names: convert g2 to G2.

fgm’s picture

fgm
Primary language French
Location Paris, France
CreditAttribution: fgm commented
Version: 7.x-1.x-dev » 6.x-1.x-dev
Status: Needs review » Patch (to be ported)

Committed to 7.x-1.x. To be backported to 6.x.

fgm’s picture

fgm
Primary language French
Location Paris, France
CreditAttribution: fgm commented
Version: 6.x-1.x-dev » 7.x-1.x-dev
Status: Patch (to be ported) » Needs work

Actually, phpcs finds many more issues than coder: more formatting fixes needed.

fgm’s picture

fgm
Primary language French
Location Paris, France
CreditAttribution: fgm commented
Status: Needs work » Needs review
FileSize
coding_standards_phpcs-1372746-4.patch0 bytes

And a few hundred (mostly commenting) changes to mostly appease PHPCS.

fgm’s picture

fgm
Primary language French
Location Paris, France
CreditAttribution: fgm commented
Version: 7.x-1.x-dev » 6.x-1.x-dev
Status: Needs review » Patch (to be ported)

Committed to 7.x-1.x.

  • fgm committed 067a550 on 8.x-1.x 
    Issue #1372746: Coding standards cleanup

- moved non-namespaced code to...
  • fgm committed 7ea311c on 8.x-1.x
    Issue #1372746 by fgm: Coding and commenting style changes for PHPCS

-...
fgm’s picture

fgm
Primary language French
Location Paris, France
CreditAttribution: fgm commented
Version: 6.x-1.x-dev » 8.x-1.x-dev
Issue summary: View changes

  • fgm committed 6639f7de on 8.x-1.x 
    Issue #1372746 byu fgm: first batch of CS fixes.

  • fgm committed f9407bb3 on 8.x-1.x 
    Issue #1372746 by fgm: Coding standards cleanup
fgm’s picture

fgm
Primary language French
Location Paris, France
CreditAttribution: fgm at OSInet commented
Status: Patch (to be ported) » Fixed

Status: Fixed » Closed (fixed)

Automatically closed - issue fixed for 2 weeks with no activity.