Problem/Motivation

#3110553: Allow FullcalendarViewProcessor plugins to define supported field types introduced a field_types property to the fullcalendar_view_processor Plugin.
In fullcalendar_view.theme.inc this property from all plugins are added to one array.

They should be merged properly

Steps to reproduce

Install 2 modules with a fullcalendar_view_processor plugin which define field_types e.g. smart_date and a custom.

Proposed resolution

Properly merge field_types of all plugins

Remaining tasks

User interface changes

API changes

Data model changes

none

Issue fork fullcalendar_view-3461385

Command icon Show commands

Start within a Git clone of the project using the version control instructions.

Or, if you do not have SSH keys set up on git.drupalcode.org:

About issue forks

Comments

luenemann created an issue. See original summary.

luenemann opened merge request !69

luenemann’s picture

luenemann
Primary language German
Location Südbaden, Germany
commented
Status: Active » Needs review

Please review the MR !69

mingsong’s picture

mingsong
Location 🇦🇺
commented

Thanks @Matthias for reporting it and the MR.

I identify another issue, maybe, with the following line in that commit.

https://git.drupalcode.org/project/fullcalendar_view/-/commit/91125f112d...

I think the comparison should be changed to 

if ($start_field_option['type'] === $fieldtype) {
  $valid = TRUE;
  break;
}
mingsong’s picture

mingsong
Location 🇦🇺
commented

Here is the patch for the MR.

https://git.drupalcode.org/project/fullcalendar_view/-/merge_requests/69...

We need someone has the Smart Date module or any other module that implements the fullcalendar_view_processor plugin installed on their site to test and confirm for us.

So I will leave it as 'Needs review'.

luenemann’s picture

luenemann
Primary language German
Location Südbaden, Germany
commented
Status: Needs review » Needs work

@Mingsong thanks you for the review, sorry for the late response.

I have reviewed your changes and think they should be reverted, see the comments in the MR.

Maybe it is possible to add an integration test with smart_date. I'd like to give it a try.