Problem/Motivation

Drush make can download the FullCalendar library, but I don't know of any way using Drush to move around folders that have been downloaded. The installation procedure for this module requires that fullcalendar.min.js is put in the immediate sub folder (eg. sites/all/libraries/fullcalendar/fullcalendar.min.js), which afaik requires manual work. This makes it difficult or impossible to create sites using FullCalendar with Drush make.

Proposed resolution

Allow using the original folder structure of the FullCalendar library, eg. reading from sites/all/libraries/fullcalendar/fullcalendar/fullcalendar.min.js.

Remaining tasks

Evaluate if this is a good idea (or if I just missed something in Drush make).
Write patch.
Evaluate, iterate.
Commit.

User interface changes

–

API changes

Hopefully none.

CommentFileSizeAuthor
#5 1867756-5-keep_original_library_structure.patch1.99 KBItangalo
#4 1867756-4-keep_original_library_structure.patch512 bytesItangalo
#1 1867756-1-keep_original_library_structure.patch494 bytesItangalo
Support from Acquia helps fund testing for Drupal Acquia logo

Comments

Itangalo’s picture

Itangalo CreditAttribution: Itangalo commented
Status: Active » Needs review
FileSize
1867756-1-keep_original_library_structure.patch494 bytes

Patch attached.

geek-merlin’s picture

geek-merlin
they/omg
Primary language German
Location Freiburg, Germany
CreditAttribution: geek-merlin commented

i think this is the way to go.

what should we do to upgraders?

Itangalo’s picture

Itangalo CreditAttribution: Itangalo commented

Hm, good question.

One way is to extend the patch, and have FullCalendar look for the library in two directories. I'm not 100% sure that's possible, and it would lead to legacy code.
The other approach, of course, is to have people manually move the directory for the FullCalendar library. I expect most people would miss that update instruction, though.

Itangalo’s picture

Itangalo CreditAttribution: Itangalo commented
FileSize
1867756-4-keep_original_library_structure.patch512 bytes

It turns out that there is need for another minor code change, used when the Libraries module is enabled.
Patch attached.

Itangalo’s picture

Itangalo CreditAttribution: Itangalo commented
FileSize
1867756-5-keep_original_library_structure.patch1.99 KB

About #2: Attached is a patch that allows both the old file structure and the new, intact, library structure.

I'm not sure that it's the way to go – this has some extra if statements – but at least it works.

I noticed the includes/fullcalendar.drush.inc file, that can be used to download the library.
If the intact library structure should be used, then drush_fullcalendar_plugin() should be updated.

Does anyone know if there are any particular reasons to why the demos and jQuery directories should be removed (according to the old installation instructions). (Could there be security implications if they are kept?)