Support for Drupal 7 is ending on 5 January 2025—it’s time to migrate to Drupal 10! Learn about the many benefits of Drupal 10 and find migration tools in our resource center.I ran it through the new automated coder review: http://qa.drupal.org/pifr/test/199653
Half of these are false positives, see #822260: Coder does not recognize class or method names in @see blocks. and #737372: Overly aggressive matching on "date" pattern.
| Comment | File | Size | Author |
|---|---|---|---|
| #4 | fullcalendar-1361540-4.patch | 9.96 KB | tim.plunkett |
| #1 | fullcalendar-1361540-1.patch | 11.66 KB | tim.plunkett |
Comments
Comment #1
tim.plunkettHere's a start. Unfortunately, d.o also uses Coder Tough Love, and that's 6.x only, so I don't know how to run it locally.
It complains about "FullCalendar Colors" being title case, but I think I'll just ignore it because "FullCalender options" is too confusing compared to "FullCalendar Options".
Comment #2
aspilicious CreditAttribution: aspilicious commentedLooks good
Comment #3
tim.plunkettMade one commit: http://drupalcode.org/project/fullcalendar.git/commit/f8f5d18
Postponing until the testbot false positives are cleared up, and then I'll retest.
Comment #4
tim.plunkettI ran it through jslint, here's some cleanup.
Comment #5
tim.plunkettCommited http://drupalcode.org/project/fullcalendar.git/commit/b0bf1d0 and http://drupalcode.org/project/fullcalendar.git/commit/8e2a263, moving back to postponed until the testbots are updated.
Comment #6
tim.plunkettClosing this. I'm never using a <br /> no matter what.