Our server have been recently upgraded to php 5.3 (We have Drupal 6.14 installed)
When trying to establish a friendship between two users, the requester gets the message:

warning: Parameter 2 to friendlist_ui_relation_form() expected to be a reference, value given in /includes/form.inc on line 372.

and the friendship request is not created.

CommentFileSizeAuthor
#15 warn_arg_passed_by_value-746106-1.patch462 bytessavedario
Support from Acquia helps fund testing for Drupal Acquia logo

Comments

savedario’s picture

I tried an emergency fix and changed friendlist_ui/friendlist_ui.module:207 from

function friendlist_ui_relation_form(&$form_state, &$form_params) {

to

function friendlist_ui_relation_form(&$form_state, $form_params) {

The form gets composed properly and friendships can be requested as expected.

Sorry, I can't produce a patch.

pravsify’s picture

Thanks this solved my problem let me know y this has been created

pravsify’s picture

Thanks a lot y this has occured

savedario’s picture

No problem.

Apparently php 5.3 introduces a few changes and, by default, those appear as errors (the new E_DEPRECATED seen above).
Many modules are not fully 5.3 compatible yet.

Search with php 5.3 and you will find several cases of this.

johnhesston’s picture

Thank you so much for this!

sarav.din33’s picture

Hi savedario,

After i change the friendlist_ui/friendlist_ui.module:207 from

function friendlist_ui_relation_form(&$form_state, &$form_params) {

to

function friendlist_ui_relation_form(&$form_state, $form_params) {

After that i logged in as "admin" send the request to "user"

I got the message as follows,

Request has been sent successfully.

Then i check the user account there is no friends request (i think i dont know where to check that friends request).

Please guide me on this issue as soon as possible....

Thanks & Regards
Sarav.....

sarav.din33’s picture

Hi savedario,

first of all thank you for this..... i got the output

savedario’s picture

I am glad it helped.
I am having the same issue (no notification/email when a friendship is requested).
How did you solve your problem ?

sarav.din33’s picture

Hi savedario,

Instead of got the email, go to the following link,

Home > My account >

After that you will see Community tab in that page.

Click that tab you will see the corresponding friends request you send earlier.

I think this enough to solve your problem...

Please help me on the following issue as soon as possible,

How to list the friends list in front page.

Thanks & Regards
Sarav...

savedario’s picture

Hi Sarav...

I knew where to find the pending friendship requests. My problem is more related with the message/email that should be sent to a user when another requests friendship.

About showing the list of friends on front page, I've done something similar using a panel that shows the view (the one with path user/xxx/community).

sarav.din33’s picture

Hi savedario,

My friend also enable the friendlist modules to his community site.

Logged in as an "administer" send friend request to "user10". Then he got successfully send request message.

But in the "User10" my account page there is nothing in received request.

Please guide me on this issue as soon as possible.

Thanks & Regards
Sarav...

savedario’s picture

Sorry for this late reply.
Unfortunately I am in no condition to provide help in debugging your friend's issue.
It also seems a bit off-topic here, so you'd better create a separate issue for it.

Good luck

savedario’s picture

Category: support » bug
FileSize
462 bytes

Although this is an old issue, I submit a patch just for house-keeping purposes.
(Thanks to the newly discovered patching instructions).