Closed (fixed)
Project:
Freelinking
Version:
4.0.x-dev
Component:
Code
Priority:
Normal
Category:
Bug report
Assigned:
Unassigned
Reporter:
Created:
14 Dec 2024 at 19:35 UTC
Updated:
28 Dec 2024 at 20:19 UTC
Jump to comment: Most recent
When viewing the Compose tips page, the settings may not be available when the DrupalOrg plugin is enabled.
This does not occur for the External links plugin, which the Drupalorg plugin class extends.
Warning: Undefined array key "settings" in Drupal\freelinking\Plugin\freelinking\DrupalOrg->getIndicator() (line 32 of modules/contrib/freelinking/src/Plugin/freelinking/DrupalOrg.php).
Drupal\freelinking\Plugin\freelinking\DrupalOrg->getIndicator() (Line: 181)
Drupal\freelinking\Plugin\Filter\Freelinking->tips() (Line: 274)
Fix the issue and write a functional test to assert tips output.
The tips page does not instantiate the plugin with configuration array, but with settings. Apparently the only thing that used its settings was DrupalOrg plugin.
- None
Start within a Git clone of the project using the version control instructions.
Or, if you do not have SSH keys set up on git.drupalcode.org:
Comments
Comment #2
mradcliffeComment #4
mradcliffeThis should now fail because of the PHP warning.
Comment #5
mradcliffeShould be resolved now.
Comment #7
mradcliffeLooks good locally and with test run.
Quick merge.