During my tests I've found out that the recipient list validation / tokenization seems to be broken in some ways:

  1. It accepts whitespace only recipients.
  2. One recipient can be inserted multiple times.
  3. Empty lines (surrounded by valiad addresses) are not discarded.
CommentFileSizeAuthor
#2 2156051-unify-recipient-address-handling-2.patch1.97 KBtorotil
#1 2156051-unify-recipient-address-handling-1.patch1.97 KBtorotil
Support from Acquia helps fund testing for Drupal Acquia logo

Comments

torotil’s picture

torotil CreditAttribution: torotil commented
Version: 7.x-2.0 » 7.x-2.x-dev
Status: Active » Needs review
FileSize
2156051-unify-recipient-address-handling-1.patch1.97 KB

Here is a patch. It also unifies the recipient handling in the validate function and forward_recipient_list().

torotil’s picture

torotil CreditAttribution: torotil commented
FileSize
2156051-unify-recipient-address-handling-2.patch1.97 KB

Ok here another fixup for a bogus empty() call.

john.oltman’s picture

john.oltman CreditAttribution: john.oltman commented
Title: Recipient list validation broken. » Improve recipient list validation
Status: Needs review » Fixed

Thanks for the patch, tested and applied to DEV branch

Status: Fixed » Closed (fixed)

Automatically closed - issue fixed for 2 weeks with no activity.