On the Block layout page, I get the following warnings:

Notice: Undefined offset: 0 in formdazzle_add_form_element_suggestions() (line 101 of modules/contrib/formdazzle/formdazzle.module).
Notice: Array to string conversion in formdazzle_add_form_element_suggestions() (line 135 of modules/contrib/formdazzle/formdazzle.module).
CommentFileSizeAuthor
#5 3089028-5.patch6.94 KBJohnAlbin
#4 3089028-4.patch2.68 KBJohnAlbin
#2 3089028-undefined-offset-and-array-to-string-conversion-2.patch4.01 KBdan2k3k4
#3 interdiff_2-3.txt1.17 KBdspachos
#3 3089028-undefined-offset-and-array-to-string-conversion-3.patch4.78 KBdspachos
Support from Acquia helps fund testing for Drupal Acquia logo

Comments

dan2k3k4 created an issue. See original summary.

dan2k3k4’s picture

dan2k3k4 CreditAttribution: dan2k3k4 at Amazee Labs commented
Assigned: Unassigned » dan2k3k4
Status: Active » Needs review
FileSize
3089028-undefined-offset-and-array-to-string-conversion-2.patch4.01 KB
dspachos’s picture

dspachos CreditAttribution: dspachos as a volunteer commented
FileSize
3089028-undefined-offset-and-array-to-string-conversion-3.patch4.78 KB
interdiff_2-3.txt1.17 KB

Some times $element['#theme_wrappers'] contains container render element as nested array. Remove to avoid notice for array to string conversion (and add again after merge).

JohnAlbin’s picture

JohnAlbin
he/they/他
Primary language English
Location Taipei, Taiwan
CreditAttribution: JohnAlbin at Amazee Labs commented
Version: 8.x-1.0 » 2.x-dev
Related issues: +#3168891: Undefined offset error for theme_wrappers
FileSize
3089028-4.patch2.68 KB

Re-rolled without all the code formatting that was fixed in #3178145: Update code syntax using phpcs/phpcbf

JohnAlbin’s picture

JohnAlbin
he/they/他
Primary language English
Location Taipei, Taiwan
CreditAttribution: JohnAlbin at Amazee Labs commented
FileSize
3089028-5.patch6.94 KB

I realized I can get rid of the whole array_unique(array_merge mess by using the array + operator like Drupal\Core\Render\Renderer::doRender() does.

And I'm also checking the wrong array indices so the code that is throwing the undefined offset is doubly wrong.

Here's the new patch

  • JohnAlbin committed 494c4b6 on 2.x 
    Issue #3089028 by JohnAlbin, dspachos, dan2k3k4: Undefined offset and...
JohnAlbin’s picture

JohnAlbin
he/they/他
Primary language English
Location Taipei, Taiwan
CreditAttribution: JohnAlbin at Amazee Labs commented
Assigned: dan2k3k4 » Unassigned
Status: Needs review » Fixed

Status: Fixed » Closed (fixed)

Automatically closed - issue fixed for 2 weeks with no activity.