Problem/Motivation

Currently the selected form can't be changed after the block instance is created.

Proposed resolution

Update the variable $contactForm every time the block config is changed using either setConfiguration or setConfigurationValue.

Remaining tasks

None.

User interface changes

None.

API changes

None.

Data model changes

None.

CommentFileSizeAuthor
#2 formblock-setconfiguration-2604004-2.patch1.27 KBjuhog
Support from Acquia helps fund testing for Drupal Acquia logo

Comments

juhog created an issue. See original summary.

juhog’s picture

juhog CreditAttribution: juhog at Druid commented
FileSize
formblock-setconfiguration-2604004-2.patch1.27 KB

This patch updates the $contactForm variable when the block config is changed using either setConfiguration or setConfigurationValue.

lauriii’s picture

lauriii
he/him
Primary language Finnish
Location Finland
CreditAttribution: lauriii at Druid commented
Version: 8.x-1.0-beta7 » 8.x-1.x-dev
juhog’s picture

juhog CreditAttribution: juhog at Druid commented
Status: Active » Needs review
mikey_p’s picture

mikey_p CreditAttribution: mikey_p commented
Status: Needs review » Postponed (maintainer needs more info)

Looking at this I probably should just avoid instantiating the contact form until we need it in build(). As it is though, it is always loaded form configuration, so I'm not sure what the use case is for updating the configuration after the block has been instantiated?

  • mikey_p committed 4ad59d7 on 8.x-1.x 
    Issue #2604004: Don't set contact form in constructor.
mikey_p’s picture

mikey_p CreditAttribution: mikey_p commented
Status: Postponed (maintainer needs more info) » Fixed

Status: Fixed » Closed (fixed)

Automatically closed - issue fixed for 2 weeks with no activity.