For background to this issue, see thread in #687676: Disable footnotes outside of the normal view

Part of the problem is that the footnotes module uses <ol>. That means losing the CSS generates a huge problem (i.e. 1. 1., 2. 2., etc.) At least, using UL helps since that way you get a dot + 1., dot + 2. instead of the doubling numbering.

There is a simple sample:

With <ol>

1. 1. Note 1
2. 2. Note 2

With <ul>

* 1. Note 1
* 2. Note 2

And my problem appeared in my RSS feed which I find more dramatic than the Print module which much less people use on my sites. Several entries with notes appear in the feed (at least at time of writing):

http://www.turnwatcher.com/rss.xml

I'm attaching a patch. Please, check it out and mark this issue as "reviewed & tested by the community" so we have a chance to get this in the next version of footnotes.

Footnotes uses an OL list for the list of footnotes. However, to make the footnote number clickable, the actual list number is hidden with CSS and instead a number with link is printed into the text of the footnote: <a href="...">1.</a>...footnote text...

OL was used here because 1) a list of footnotes is a numbered list, and 2) we want to use only HTML that passes the HTML filter in a default installation of Drupal.

Comments:

Requirement 1 is kind of outdated. The introduction of the footnote number being a clickable link makes the main original reason for using OL go away. Also the introduction of the ability to specify arbitrary footnote label means that the footnotes are no longer an ordered/numbered list since the label can be arbitrary.

To satisfy requirement 2, using UL is indeed fine.

1st quick review of the patch, not able to test while traveling:
* Changing to UL is ok
* Comments in CSS should be edited to reflect this change. (In the patch, one comment is removed, another is left there but still refers to using numbered list. Both should stay and be edited to be correct.)

CommentFileSizeAuthor
#1 footnotes-numbered_list-6.x.patch1.31 KBhingo
Support from Acquia helps fund testing for Drupal Acquia logo

Comments

hingo’s picture

hingo CreditAttribution: hingo commented
Status: Active » Needs review
FileSize
footnotes-numbered_list-6.x.patch1.31 KB

Here's the patch from the other thread. Even if I already commented on it above, I will make status to "needs review" so I (or someone else) can actually test it.

AlexisWilke’s picture

AlexisWilke CreditAttribution: AlexisWilke commented
Assigned: Unassigned » AlexisWilke

Thank you Hingo. 8-)

Another way would be to completely avoid the use of UL + LI, which means we'd avoid the bullet points... but that is not as good, I think, since that won't be indented either.

Alexis

hingo’s picture

hingo CreditAttribution: hingo commented

The problem is that we need to use some tags that are valid HTML. For one thing, so that we can manipulate it with CSS. The rule "only use tags that are allowed in HTML filter with default settings" restricts us to:

<a> <em> <strong> <cite> <code> <ul> <ol> <li> <dl> <dt> <dd>

So either UL or OL is pretty much it. (I experimented with DT/DD at a time too, but it was impossible to make it look any good.)

AlexisWilke’s picture

AlexisWilke CreditAttribution: AlexisWilke commented

Yeah... I never use the dt/dd either. Never have been able to make them work properly. So ul/li seems the best choice at this point.

hingo’s picture

hingo CreditAttribution: hingo commented
Status: Needs review » Fixed

Fix for this bug was committed and will be in a future 6.x-2.4 release once I fix more bugs first.

As part of this, I filed a bug against Garland, the default Drupal theme #861634: Document usage of background instead of list-style-image for unordered lists.

Status: Fixed » Closed (fixed)

Automatically closed -- issue fixed for 2 weeks with no activity.