Problem/Motivation

Hello.

I am using the module, it works fine except for several things.
The most undesirable thing is that when I use the functionality to remove empty cells, at the end of the table on the right the lines below remain. You can see it in the photo. I have used the same table with the default table of the views, with the same functionality and there is no remaining line.

Gracias

Steps to reproduce

Proposed resolution

Remaining tasks

User interface changes

API changes

Data model changes

CommentFileSizeAuthor
#8 footable-1.png331.75 KBsourabhsisodia_
Screenshot 2024-12-26 215912.jpg45.93 KBady1503

Issue fork footable-3496118

Command icon Show commands

Start within a Git clone of the project using the version control instructions.

Or, if you do not have SSH keys set up on git.drupalcode.org:

About issue forks

Comments

ady1503 created an issue. See original summary.

sourabhsisodia_ made their first commit to this issue’s fork.

ady1503’s picture

ady1503 commented

Hello.

I have found where these lines come from, they are from the admin Gin theme, they are the following lines:

table tbody tr {
  border-block-end: 1px solid var(--gin-border-color-table);
}

and

table thead tr {
  border-block-end: 2px solid var(--gin-border-color-table-header);
}

I altered the Gin css off this lines and works perfect.

Not sure if footable module may alter in views if is selected, for not alter with custom code.

Gracias

sourabhsisodia_’s picture

sourabhsisodia_ commented
Assigned: Unassigned » sourabhsisodia_

sourabhsisodia_ opened merge request !5

sourabhsisodia_’s picture

sourabhsisodia_ commented
Assigned: sourabhsisodia_ » Unassigned
Status: Active » Needs review
ady1503’s picture

ady1503 commented

Hello.

I have applied the patch and there is no change.

It does not act on the alter of the Gin theme.

And yes, I delete all drupal caches.

Gacias

sourabhsisodia_’s picture

sourabhsisodia_ commented
StatusFileSize
new footable-1.png331.75 KB

@ady1503 Attaching a screenshot . Is it the correct configuration for the issue ??

ady1503’s picture

ady1503 commented

Hello.

Your patch works, I found that when applying the patch in automatic mode, the changes in the file:
footable.libraries.yml are not applied correctly.
I have made the changes to this file manually and everything works fine.

Gracias.

sourabhsisodia_’s picture

sourabhsisodia_ commented

hii @ady1503, if the patch works fine then please move the issue to " Review and Tested By Community " state and mention the maintainer to review and merge the MR . So that this issue get fixed in the dev version also.

ady1503’s picture

ady1503 commented
Status: Needs review » Reviewed & tested by the community