Hello,

As the usage of Composer is rising to manage Drupal modules and libraries, I think it will be good to use the "compiled" sub-folder of the Footable libraries to ease the download of this external library.

I will provide a patch for that.

CommentFileSizeAuthor
#4 footable-1.0-alpha2-composer-2881979-4.patch2.42 KBb-prod
#3 footable-1.0-alpha2-composer-2881979-3.patch2.49 KBb-prod
#2 footable-composer-2881979-2.patch2.83 KBgrimreaper

Comments

Grimreaper created an issue. See original summary.

grimreaper’s picture

grimreaper
Primary language French
Location France 🇫🇷
commented
Assigned: grimreaper » Unassigned
Status: Active » Needs review
StatusFileSize
new footable-composer-2881979-2.patch2.83 KB

Here is the patch that changes the path to the CSS/JS files for the library and add an example for composer usage in the README.

Thanks for the review.

b-prod’s picture

b-prod commented
StatusFileSize
new footable-1.0-alpha2-composer-2881979-3.patch2.49 KB

Just a patch for the current version, so it can be use in Composer.

b-prod’s picture

b-prod commented
StatusFileSize
new footable-1.0-alpha2-composer-2881979-4.patch2.42 KB

Sorry, wrong file :-(

b-prod’s picture

b-prod commented
Status: Needs review » Reviewed & tested by the community

Patch #2: fixes the issue on the DEV version.

geek-merlin’s picture

geek-merlin
Primary language German
Location Freiburg, Germany
commented

Just FYI: This approach requires us to add a VCS repo for each and any lib either to packagist.org or to our global composer.json.

With this module (unpatched) i have good experience with this approach (which assumes vendor dir is above drupal root!):

composer config repositories.asset-packagist composer https://asset-packagist.org # We only need this once and get lots of libs.
composer require npm-asset/footable
ln -s ../../vendor/npm-asset/footable/compiled/ libraries/footable # Nice: We can link subdirs so no exploitable demo code is seen in webroot.