CommentFileSizeAuthor
#6 fontawesome_extract_icons.patch456 bytesalez.k
#5 2840021+2427005.patch23.21 KBoriol_e9g
#2 awesome470.patch1.39 KBoriol_e9g
Support from Acquia helps fund testing for Drupal Acquia logo

Comments

oriol_e9g created an issue. See original summary.

oriol_e9g’s picture

oriol_e9g
Primary language Catalan
Location Barcelona
CreditAttribution: oriol_e9g at Diputació de Barcelona commented
Status: Needs work » Needs review
FileSize
awesome470.patch1.39 KB
oriol_e9g’s picture

oriol_e9g
Primary language Catalan
Location Barcelona
CreditAttribution: oriol_e9g at Diputació de Barcelona commented

First we need to commit this #2427005: Extract icons automatically to support fa icons.

oriol_e9g’s picture

oriol_e9g
Primary language Catalan
Location Barcelona
CreditAttribution: oriol_e9g at Diputació de Barcelona commented
Parent issue: » #2427005: Extract icons automatically
oriol_e9g’s picture

oriol_e9g
Primary language Catalan
Location Barcelona
CreditAttribution: oriol_e9g at Diputació de Barcelona commented
FileSize
2840021+2427005.patch23.21 KB

Only for testing purposes this is the combined patch: #2840021: Use the last FontAwesome version as default 4.7.0 + #2427005: Extract icons automatically

alez.k’s picture

alez.k CreditAttribution: alez.k as a volunteer commented
FileSize
fontawesome_extract_icons.patch456 bytes

Hi,
the regex used in fontawesome_extract_icons() for the 4.7.0 version returns a wrong result because of the presence of new patterns in the css classes.
I've extended the rules.

Chris Charlton’s picture

Chris Charlton
Primary language English
Location Los Angeles
CreditAttribution: Chris Charlton as a volunteer commented

7.x?

Daniel.Moberly’s picture

Daniel.Moberly CreditAttribution: Daniel.Moberly commented
Status: Needs review » Closed (outdated)

Addressed in #2896350: Update CDN to 4.7.0. Continue the discussion there