Support for Drupal 7 is ending on 5 January 2025—it’s time to migrate to Drupal 10! Learn about the many benefits of Drupal 10 and find migration tools in our resource center.
I am providing a working module that adds Pinterest support. The code attached is not a patch file. I needed Pinterest support quickly so an add-on module was the quickest step at the time; a patch can be made from these files.
I am attaching a working D7 module (files and graphics) for Pinterest Follow support. I'd like to offer it first here for contribution before spawning another sandbox. Let me know if you want to include this.
Comment | File | Size | Author |
---|---|---|---|
#14 | follow-added_support_for_pinterest-1667782-14.patch | 7.13 KB | BWPanda |
Comments
Comment #1
WeRockYourWeb.com CreditAttribution: WeRockYourWeb.com commentedFantastic, works perfectly. Thanks for creating this add-on Chris!
Would love to see this officially added to the module. Given the popularity of Pinterest, I think this is a must.
Comment #2
laughnan+1 @Chris Charlton
Comment #3
Chris CharltonWould the module maintainers like me to generate an official patch for Pinterest support? LMK
Comment #4
staff_whyte CreditAttribution: staff_whyte commented+1
Comment #5
sk33lz CreditAttribution: sk33lz commentedChris, please provide a patched version so the community can review and test it so that it may possibly be accepted into the module.
Thanks!
Comment #6
floydm CreditAttribution: floydm commentedA patch made against the current 7.x-1.x branch in git is attached.
The two icons also need to be dropped into the icons/large and icons/small directories.
Comment #7
Chris Charlton@Floydm, did you generate the patch using my Pinterest ZIP file above?
@Matainers, let us know if Floydm's patch is good enough otherwise I'll generate another.
Comment #8
floydm CreditAttribution: floydm commented@Chris Charlton My patch adds Pinterest to the core follow module rather that uses an additional module but it is based on your work.
@Maintainers: if I could help roll this patch and a few others into a single patch, please let me know! I'd love to see follow get a stable 7.x-1.0 version before the time comes to start work on the 8.x version.
Candidates for a mega patch:
#1667782: Pinterest support
#1667778: Undefined index in theme_follow_links() when custom follow add-on modules disabled
#1879484: Support for instagram and pinterest
#1729028: Google+ Needs rel="publisher" in link
#1667778: Undefined index in theme_follow_links() when custom follow add-on modules disabled
#1419474: Add Views to D7 version of Follow
Comment #9
sk33lz CreditAttribution: sk33lz commentedPatch works great against 7.x-1.x-dev. Thanks!
This is why the Drupal community rocks :D
Comment #10
q0rban CreditAttribution: q0rban commentedOk, we have duplicate issues here, each set to RTBC (See #1895014: Support Pinterest). Can someone review both patches please and make a call on which to use?
Comment #11
irk CreditAttribution: irk commentedAfter reviewing both patches, I would say @Floydm's patch suits better since it adds the icons. But I'm confused why the images themselves can't be included in the patch.
EDIT: Actually the other patch is for the 2.x branch so it's not a duplicate. By what I can see, each should be applied to their respective branch.
Comment #12
irk CreditAttribution: irk commentedAttaching updated patch with the new image files included. The code hasn't changed other than removing added whitespaces in the module file. Good work @Floydm.
Comment #14
BWPanda CreditAttribution: BWPanda commentedHere's a patch for the 7.x-2.x branch that adds support for Pinterest with icons. Note that it requires the patch from #2209847: Add new icons from Paul Robert Lloyd's socialmediaicons to add one of the new icons.
Once this is tested and committed it can be backported to the 7.x-1.x branch.
Comment #15
BWPanda CreditAttribution: BWPanda commentedMarked #1895014: Support Pinterest as a duplicate of this issue.