Access Check Missing Warning for D10

Guess this should be TRUE, not FALSE ;)

No idea what that patch does :D Not even the variable exists?

Edit: Sorry I was wrong, the variable exists ;)

@Grevil: Please review

Seems odd to me... I guess we need to also add the access check for:

      $first = clone $query;
      $prev = clone $query;
      $next = clone $query;
      $last = clone $query;

But I don't get, why we can not simply use the access check of the original query... oh well.

@Grevil indeed sorry! Yes the same question came to my mind... perhaps because it's a method? We shouldn't dig too deep?
I would remove the whole clone in a refactoring, I think. Quite risky.

I agree, I don't even think it is possible to add an access check later on to a populated query. So removing the clone is probably our only option here... A bit unfortunate, since we create duplicate code this way...

On further inspection, this kind of seems like a core bug. As stated in https://www.drupal.org/node/3201242, the warning

Relying on entity queries to check access by default is deprecated in drupal:9.2.0 and an error will be thrown from drupal:10.0.0. Call \Drupal\Core\Entity\Query\QueryInterface::accessCheck() with TRUE or FALSE to specify whether access should be checked.

Should only appear if accessCheck() is called without any parameters given.

But in this case, we explicitly set 'accessCheck(TRUE)' on the original query and clone the query object 4 times, meaning the cloned object should also have their accessCheck set explicitly!

I just reread the issue summary and found out, that this isn't an actual error, but instead output by upgrade status...

Have you actually seen the error get thrown using Drupal 10? My guess is, that the upgrade status module isn't smart enough to see, that the explicit access check was simply cloned from the original query object.