Flexslider added support to disable fade animation for first slide with fadeFirstSlide option for quite some time https://github.com/woocommerce/FlexSlider/pull/1099/commits/bfa59155cb5b....

With this option we can disable fade on first slide which is most of the time pretty ugly and not wanted effect.

So we should add support for it into this module also.

CommentFileSizeAuthor
#2 add-support-for-fadefirstslide-option-2867558-2.patch1.5 KBpivica
Support from Acquia helps fund testing for Drupal Acquia logo

Comments

pivica created an issue. See original summary.

pivica’s picture

pivica CreditAttribution: pivica at MD Systems GmbH commented
Status: Active » Needs review
FileSize
add-support-for-fadefirstslide-option-2867558-2.patch1.5 KB

Here is a patch.

minorOffense’s picture

minorOffense CreditAttribution: minorOffense at Coldfront Labs Inc. commented

What version of flex slider was that introduced? If it's enabled on an older version of the library does it cause any issues?

pivica’s picture

pivica CreditAttribution: pivica at MD Systems GmbH commented

As stated in https://github.com/woocommerce/FlexSlider/pull/1099/commits/bfa59155cb5b... this commit landed on May 4, 2014 - so almost 3 years ago - so its not a new thing and i guess it went into version 2.3.0 of flexslider lib.

Didn't tested really will it create some problem on versions before 2.3.0 - 3 years is pretty old already.