Problem/Motivation

When the flag module was updated to 8.x-4.0-beta6 a call using build(...) in FlagLinkBuilderInterface must be updated due to an extra parameter added.

Steps to reproduce

Install flag module 8.x-4.0-beta6 and it will crash.

Proposed resolution

Fix the definition in FlagListsFlagLinkBuilder

Remaining tasks

None

User interface changes

None

API changes

None

Data model changes

None

CommentFileSizeAuthor
#7 flag_lists-3504522.patch1.15 KByseki

Issue fork flag_lists-3504522

Command icon Show commands

Start within a Git clone of the project using the version control instructions.

Or, if you do not have SSH keys set up on git.drupalcode.org:

About issue forks

Comments

sl27257 created an issue. See original summary.

  • sl27257 committed 5d50bf0f on 4.0.x 
    Issue #3504522 by sl27257: Declaration of Drupal\flag_lists\...
sl27257’s picture

sl27257
Location Stockholm
commented

All the crashes here are related to the API update of the Flag-module. This means that the next release of the Flag Lists module will be dependent on / connected to the Flag 8.x-4.0-beta6 release.

  • sl27257 committed 2899be97 on 4.0.x 
    Issue #3504522: Declaration of Drupal\flag_lists\...

  • sl27257 committed 8ff84039 on 4.0.x 
    Issue #3504522 by sl27257: Declaration of Drupal\flag_lists\...
sl27257’s picture

sl27257
Location Stockholm
commented
Status: Active » Needs review
yseki’s picture

yseki commented
StatusFileSize
new flag_lists-3504522.patch1.15 KB

Here is the patch I did to solve this issue in one of my projects.

That fix is not enough as it is required to pass something on the $view_mode parameter.

In my project the patch has hard-coded the view mode I'm using.

sl27257’s picture

sl27257
Location Stockholm
commented

Hi,

thank you for your patch!

I take this as a proof of that the patch I pushed to the -dev release is not the wrong one!
My patch also contains the extra stuff to populate the view_mode as you have figured out.

BR

/Thomas

danlinn made their first commit to this issue’s fork.

sl27257’s picture

sl27257
Location Stockholm
commented
Status: Needs review » Fixed

Now that this issue is closed, review the contribution record.

As a contributor, attribute any organization that helped you, or if you volunteered your own time.

Maintainers, credit people who helped resolve this issue.

sl27257’s picture

sl27257
Location Stockholm
commented
Status: Fixed » Closed (fixed)