Call to a member function id() on null in flag_lists_flag_action_access

Hi,

thanks for the report!

I have seen the same error lately, during my work on #3200737: make the related_flag id unique. In these cases it has always been because I have had bugs in the implementation of the update from the old naming scheme to the new one.

So it would be good if you could figure out what originally caused the mismatch? Your fix of course work as a remedy to the error message you get. But I think there must not be a missing related flag in the first place what so ever.

BTW: I always check the different table for what is found in these. Do you have the possibility to do that? It would be interesting to know if the following match:

SELECT relatedflag FROM flagging_collection_field_data;

and

SELECT name FROM config WHERE name LIKE 'flag.flag.%';

In the second case you will get more records but the end part of the name must match the records from the first. Also look out for NULL in the queries.

Mark this as a duplicate of #3266427: Call to a member function id() on null in line 24 of modules/contrib/flag_lists/src/Access/FlaggingCollectionAccessControlHandler.php