Problem/Motivation

I see neither the user tabs (as detailed here) nor the default link field to the default (list) flag (also detailed here).

Steps to reproduce

I have tried the latest beta and dev versions on a clean Drupal 8.9.2 installation with Bartik as the default theme.

I have moved the default flag link to the top of my default Article display (1).

BUT...

Although the Tools menu item appears (2), neither the tab (3) nor the link to the default flag (4) appear...

Symptoms of the Flag lists bug

No amount of cache clearing has any effect.

There are no other no-core modules active.

Any advice gratefully recieved.

Thanks

Comments

SirClickALot created an issue. See original summary.

sl27257’s picture

Hi,

Thanks for the bug report. Unfortunately I do not have access to my development environment were I am right now so I will not be able to check it up until next week!

/Thomas

sirclickalot’s picture

Thanks Thomas,

Just clarify...

1) I am currently testing as UID:1 in addition to testing as a standard 'Authenticated' user and I have set up permissions accordingly.

2) My reported bug (above) is actually quite sound? That is to say, I have the correct expectations?

N

sl27257’s picture

There was a recent release of the flag module that could affect link handling. But the menus should be there.

Referring to your picture:

1) This is not the way I do it. I chose another option which places it automatically where the flag module places the flags. There could be something there that I have to look into.The default template should use this "right" method.

It is also not the template you will place, but the specific flag collection.

Which user you chose to play with doesn't matter. There is however a very recent patch that make the display less cluttered for user 1.

So to try it out I recommend you to create a flagging collection and see if it pops up.

Thomas

sirclickalot’s picture

Hi Thomas,

To be clear, I am already placing a flag - it's just that the flag happens to 'belong' to default template so I think my expectations are correct and theta the two missing men items should appear.

Any normal flags that I create are placed this way - by adding the field to the Manage Display page and they work fine.
Everything looks and behaves exactly as I expect and as the documentation suggests, it's just the two menu items I illustrate don't show and the flag itself does't show either.

Thanks

sl27257’s picture

The reason for it not working as you expect is that the "Flagging Collections" are not Flag entities, they are only using flags as template and the functionality.

When you click on 2) in your picture above you should see your created Flagging Collections and the items belonging to them.

Flagging Collection

Note that a Flagging Collection must be created first.

Where the link is placed is decided when you create the template. But, I admit, I have only tested the option "Display as AJAX link".

I see now when checking the "Manage display" for the Node content type that there are some items that should be removed. The Templates must not be there. Only the Flagging Collection should be there.

Node entity

Thanks for pointing this out! A will look into a fix for it.

/Thomas

sl27257’s picture

Some more comments:

Your item 3) in your picture is as it should be. If you are referring to the "My Flagging Collections" then that one is in the "Main Navigation Menu".

"There are no other no-core modules active." You should be forced to load the flag module as well. Were you not asked to do that? If it did not happen then I need to look into that as well!

sl27257’s picture

I did a complete reinstall of the flag and flag_lists module under D8.9.3 and for me it is working as I have tried to explain.

There is however one thing that I will try to enhance.

On the following page: /admin/structure/types/manage/article/display for a node of type "Article" as an example, there are both template flags and the Flagging Collection shown. As it is now it is only the flagging collections entries that affect were the link is placed. As the Flagging Collection is created "dynamically", i.e. does not show up here until the collection is created, it means that you need to go to this page after each Flagging Collection has been created. And also this admin page is normally not accessible for normal users. All together this means that the link will always be placed at its default position.

One way around this would be to change the logic so that it is the template flag position that is used instead of the Flagging Collections position. For the completeness then the Flagging collections should not be shown at all.

I will look into how to achieve this...

sl27257’s picture

(This is a note for my own memory...) The easiest way to achieve what is mentioned in #8 is to keep all as is and "only" intercept somehow and copy the weight from the template into each Flagging collection...

sl27257’s picture

Status: Active » Postponed

I have looked into to how to do #8 but I have not yet found a good working way of doing it. The easiest way currently is actually to tweak the template to put the links where you want!