Back in July, in #3446713: Drupal 11 compatibility, .gitlab-ci.yml was modified to use the CORE phpcs sniffs instead of the default sniffs.

Core is much more permissive that the sniffs that run by default on contrib, so potentially we are missing a lot of coding standards problems.

I have been wondering why certain things in the codebase that I know to be wrong don't show up as errors in the test cases (for example, using public function setUp() in test cases instead of protected function setUp(): void.

Rather than stumbling upon these things and opening up individual issues, I'm going to turn on the default phpcs testing here and see what gets called out.

Issue fork flag-3486902

Command icon Show commands

Start within a Git clone of the project using the version control instructions.

Or, if you do not have SSH keys set up on git.drupalcode.org:

About issue forks

Comments

tr created an issue. See original summary.

tr opened merge request !101

tr’s picture

tr commented
Title: [ignore] phpcs experimentation » Use default phpcs configuration in .gitlab-ci.yml
Status: Active » Needs review

Well, that identified absolutely nothing, so perhaps it's best to just use the default .gitlab-ci.yml configuration for phpcs rather than modify it?

ivnish’s picture

ivnish
he/him
commented

Yes, let's use default configuration

  • tr committed fa4c99cc on 8.x-4.x 
    Issue #3486902 by tr: [ignore] phpcs experimentation
ivnish’s picture

ivnish
he/him
commented
Assigned: tr » Unassigned
Status: Needs review » Fixed

Status: Fixed » Closed (fixed)

Automatically closed - issue fixed for 2 weeks with no activity.