In the past week testing on GitLab CI was changed to test against D11 by default. So now the Flag tests are only being tested against D11.

Here is a MR to change .gitlab-ci.yml to turn on D10 testing as well, which we should do as long as Flag supports D10.

Issue fork flag-3482068

Command icon Show commands

Start within a Git clone of the project using the version control instructions.

Or, if you do not have SSH keys set up on git.drupalcode.org:

About issue forks

Comments

tr created an issue. See original summary.

tr opened merge request !81

tr’s picture

tr commented
Status: Active » Needs review
berdir’s picture

berdir
Primary language German
Location Switzerland
commented
Status: Needs review » Needs work

current is always on by default, I don't think that needs to be added.

and previous minor is currently skipped automatically, as soon as 11.1 is out that will be useful again IMHO.

and min max PHP is IMHO not necessary. D10/11 already gives us 8.3 and 8.1 testing, php max is currently 8.3 too.

tr’s picture

tr commented
Status: Needs work » Needs review

max/min PHP are currently the same for D11, but that won't always be true. Actually could probably add next_major, even though current and next_major are both D11 right now, when D12 opens then next_major will start working. I usually set current=1 for documentation purposes, but I agree it's not needed.

So whatever you want, I think the main point is to make sure D10 is still being tested so it doesn't get accidentally broken with all these changes. I updated the MR.

  • ivnish committed f7609756 on 8.x-4.x authored by tr 
    Issue #3482068 by tr: Test against both D10 and D11
ivnish’s picture

ivnish
he/him
commented
Status: Needs review » Fixed
ivnish’s picture

ivnish
he/him
commented

Thanks, @TR!

Status: Fixed » Closed (fixed)

Automatically closed - issue fixed for 2 weeks with no activity.