Come together with the global Drupal community in Rotterdam, 28 Sept – 1 Oct 2026. Sessions, contribution, connection, and Early Bird savings until 8 June.Problem/Motivation
When the module is configured to display the reporting form in a dialog, the form is grayed out and is unusable. This doesn't happen in all cases and seems dependent on factors such as theme styles, etc.
Steps to reproduce
Go to a node that has comments on it. Click on the link to flag a comment. When the dialog opens, it is grayed out and unusable.
Proposed resolution
In my case, this was only happening for specific roles so I initially thought it was a permissions related issue, but upon further investigation it was determined that a z-index was not being applied to both the dialog and it's overlay.
Reviewing the API documentation for Ajax Dialog Boxes it appears that the Flag module fails to define the required dependency on the core/drupal.dialog.ajax library. Applying this dependency and rebuilding Drupal's cache appears to have fixed the issue. See attached patch.
Remaining tasks
Review the attached patch
User interface changes
API changes
Data model changes
| Comment | File | Size | Author |
|---|---|---|---|
| #2 | flag--3335892--flagging-modal-no-zindex.patch | 292 bytes | j.cowher |
| Screenshot 2023-01-23 at 12.16.01 PM.png | 27.3 KB | j.cowher | |
| Screenshot 2023-01-23 at 12.06.59 PM.png | 45.8 KB | j.cowher |
Issue fork flag-3335892
Show commands
Start within a Git clone of the project using the version control instructions.
Or, if you do not have SSH keys set up on git.drupalcode.org:
changes
Comments
Comment #2
j.cowher commentedComment #3
j.cowher commentedComment #7
ivnish