Fix coding standard - Inline @var declarations should use the /** */ delimiters

Hey @sharayurajput,

since there is no activity for 5 days. I am assigning this to myself.

Hi,

I have resolved all issues where the @var tag were declared inline and needed "/** */" delimiters.

I will upload a patch.

Thanks

Hi,

Please review this patch.

Thanks

#7 having whitespace errors.

Hi,
i will review this patch.

#9patch resolved a number of coding standards issues, but there are still many remaining, so moving to needs work

Resolved remaining phpcs issues in #9 patch.

I'll review it

The phpcs errors are still appearing, actually there are too many...

sorry, I didn't see something. The coding standards related with Inline @var declarations are already fixed! Btw... There are other issues related with flag that are shown.

The patch in #12 is making changes unrelated to the coding standard fix:

-    $flags = \Drupal::service('flag')->getAllFlags($type);
-    $object = $data[$type];
-    foreach ($flags as $flag) {
-      foreach ($tokens as $name => $original) {
-        $flag_count_token = 'flag-' . str_replace('_', '-', $flag->name) . '-count';
-        $flag_link_token = 'flag-' . str_replace('_', '-', $flag->name) . '-link';
-        if ($name == $flag_count_token) {
-          $replacements[$original] = $flag->get_count($flag->get_entity_id($object));
-        }
-        elseif ($name == $flag_link_token) {
-          $replacements[$original] = flag_create_link($flag->name, $flag->get_entity_id($object));
-        }
-      }
-    }
+  $flags = \Drupal::service('flag')->getAllFlags($type);
+  $object = $data[$type];
+  foreach ($flags as $flag) {
+  foreach ($tokens as $name => $original) {
+  $flag_count_token = 'flag-' . str_replace('_', '-', $flag->name) . '-count';
+  $flag_link_token = 'flag-' . str_replace('_', '-', $flag->name) . '-link';
+  if ($name == $flag_count_token) {
+  $replacements[$original] = $flag->get_count($flag->get_entity_id($object));
+  }
+  elseif ($name == $flag_link_token) {
+  $replacements[$original] = flag_create_link($flag->name, $flag->get_entity_id($object));
+  }
+  }
+  }

This is a violation of the indentation standard and needs to be fixed.

Upon closer inspection, #12 is a reroll of #9, but #9 is actually fine, while #12 has indentation problems. So #9 should be the correct patch, as the issue title is "Fix coding standard - Inline @var declarations should use the /** */ delimiters", not "fix all coding standards."

Actually, #7 would be ok too I think, except the # in the patch file name breaks composer patching.

I'm setting this back to "needs review" as someone else should also confirm this analysis that #9 is the patch that best solves this issue at present.

Tested here and the #9 patch does the job in the issue scope, so i'm moving it to RTBC.

Remember to use the #9 patch as the final one.

Needs reroll to MR

None of the above patches fixed the error correctly, and all except #4 by @urvashi_vora had out-of-scope changes. I created a MR to fix just the phpcs errors mentioned in the title.

Test results show that all these errors are eliminated by the MR. This can be confirmed by searching for the sniff Drupal.Commenting.InlineVariableComment.VarInline in the phpcs test results.

MR fixed some phpcs issues but added new 4 phpstan issues

Ok, I don't see any code that can add new phpstan issues. Merged