The protected variable name used to trigger page cache killswitch
is pageCacheKillSwitch http://cgit.drupalcode.org/flag/tree/src/Plugin/views/relationship/FlagV...

but protected variable has typo pachCacheKillSwitch

Support from Acquia helps fund testing for Drupal Acquia logo

Comments

Oleksiy created an issue. See original summary.

andypost’s picture

Title: Vews relationship label description attached to removed admin label » Fix typo in variable name FlagViewsRelationship
Issue summary: View changes
Status: Active » Needs review
FileSize
1.54 KB

re-purposed issue

Status: Needs review » Needs work

The last submitted patch, 2: 2935419-2.patch, failed testing. View results

piggito’s picture

I tested patch in #2 locally and it passed so I'm adding retest here.

andypost’s picture

Status: Needs work » Needs review

Failures are unrelated

andypost’s picture

Issue tags: +Quick fix
martin107’s picture

Status: Needs review » Reviewed & tested by the community
Related issues: +#2943184: Test instability - Random fails.

From #5 Yes I agree the test failures are unrelated.

This patch should go forward.

I think I can explain some of the random test fails, I have created an issue.

Status: Reviewed & tested by the community » Needs work

The last submitted patch, 2: 2935419-2.patch, failed testing. View results

socketwench’s picture

Status: Needs work » Reviewed & tested by the community

Agreed, patch should go forward. Test failures are unrelated.

  • andypost authored a0004ab on 8.x-4.x
    Issue #2935419 by andypost, Oleksiy, piggito, martin107, socketwench:...
socketwench’s picture

Status: Reviewed & tested by the community » Fixed

Thanks everyone!

Status: Fixed » Closed (fixed)

Automatically closed - issue fixed for 2 weeks with no activity.