There are 10 coding standard errors with the message

There must be no blank line following an inline comment.

I am working on this now.

CommentFileSizeAuthor
#4 coding-standard-2927121-4.patch4.89 KBsharayurajput

Issue fork flag-2927121

Command icon Show commands

Start within a Git clone of the project using the version control instructions.

Or, if you do not have SSH keys set up on git.drupalcode.org:

About issue forks

Comments

martin107 created an issue. See original summary.

martin107’s picture

martin107 commented
Assigned: martin107 » Unassigned

This issue will naturally lead to a discussion about removing dead code, or code which is commented out waiting for a refactor.

A discussion which needs to be had, but I want to keep up momentum on the easy fixes. so I am de-prioritizing this.

sharayurajput’s picture

sharayurajput commented
Assigned: Unassigned » sharayurajput
sharayurajput’s picture

sharayurajput commented
Assigned: sharayurajput » Unassigned
Status: Active » Needs review
StatusFileSize
new coding-standard-2927121-4.patch4.89 KB

Created a patch for this issue

libbna’s picture

libbna commented
Assigned: Unassigned » libbna

I will review this.

libbna’s picture

libbna commented
Assigned: libbna » Unassigned

Reviewed #4 patch and it LGTM. Every space has been removed.

libbna’s picture

libbna commented
Status: Needs review » Reviewed & tested by the community
ivnish’s picture

ivnish
he/him
commented
Status: Reviewed & tested by the community » Needs work
Issue tags: +Needs reroll

Needs reroll to MR

chandansha made their first commit to this issue’s fork.

chandansha opened merge request !89

chandansha’s picture

chandansha commented

I have created MR.
Please review once.
Thanks!!

chandansha’s picture

chandansha commented
Status: Needs work » Needs review

ivnish’s picture

ivnish
he/him
commented
Status: Needs review » Fixed
Issue tags: -Needs reroll

Status: Fixed » Closed (fixed)

Automatically closed - issue fixed for 2 weeks with no activity.