test should not change the scope of a flag [#2870574]

    // Switch to a global flag, the accounting rules.
    $this->flag->setGlobal(TRUE);

We don't support changing the scope of a flag, so the test should not do this either.

This probably makes the test meaningless at the moment, as the test first flags a node by two different users, then changes the flag to global. A global flag would never have the same node flagged by two users!

Comments

Comment #1

18 April 2017 at 06:56

joachim created an issue. See original summary.

Comment #2

joachim CreditAttribution: joachim commented 18 April 2017 at 13:24

I'm not actually sure what this part of the test is testing, so I've filed #2870697: getUserFlagFlaggingCount() should document its behaviour with global flags.


    // Switch to a global flag, the accounting rules.
    $this->flag->setGlobal(TRUE);
    $this->flag->save();

    // Despite being a global flag, queries about specific anonymous users can still be made.
    $rejected_count = $this->flagCountService->getUserFlagFlaggingCount($this->flag, $this->anonymousUser, $anon1_session_id);
    $this->assertEqual($rejected_count, 1, "getUserFlagFlaggingCount() ignores the session id.");