Currently the javascript flagged/unflagged message disappears always at a fixed rate. It would be great to be able to optionally set how much time before the javascript message should disappear.

Thanks in advance for the feature request consideration.

Comments

NWOM created an issue. See original summary.

joachim’s picture

joachim CreditAttribution: joachim commented
Version: 7.x-3.x-dev » 8.x-4.x-dev

New features are going on 8.x-4.x.

martin107’s picture

martin107 CreditAttribution: martin107 as a volunteer commented
Status: Active » Postponed
Parent issue: » #2764709: [Regression/Refactor] Restore Ajax link type "flag message" functionality

I see this as a child of the issue to add the JS to make the message disappear.

The latest patch for that issue hardcodes the timeout

So we can adapt the parent issue or leave this issue as a follow up

Either way I think we should postpone this issue.

joachim’s picture

joachim CreditAttribution: joachim commented

Follow-up, I would say.

Additionally, my feeling is that this is really getting into fine detail, and that someone who wants that level of control should be able to override the JS themselves. I'd be happy with this issue just ensuring that our JS is written in such a way that this sort of overriding isn't too hard to maintain.

EDIT: what I mean by that is (excuse my total lack of JS) that it would be nice if your custom JS file just has to do something like this:

$timeout = 56;
doModuleStuff();

rather than copy-paste all the flag JS code.

martin107’s picture

martin107 CreditAttribution: martin107 as a volunteer commented

@NWOM

Just a few questions ... about the flexibility you are thinking of...

Are you thinking of varying the timeout based on flag ?

so some flags are speedy while others linger to highlight their importance.

or are you thinking of a per site styling?

NWOM’s picture

NWOM CreditAttribution: NWOM commented

Thanks for taking this into consideration! I was more along the lines thinking that doing it per flag would make sense, especially if the text is longer with certain flags (which would require a few more seconds to read ). This would also make it modular enough for all purposes most likely.