Problem/Motivation
In #2834325: pointless use of user.private_tempstore when adding a flag, we removed a pointless use of tempstore when adding a flag. We also changed the flag add page's UI to add a description. This introduced a duplicate "This cannot be changed after the flag is created".

See this comment: https://www.drupal.org/node/2834325#comment-11820269
Proposed resolution
- Change the text at the top of the form to: "Select the type of flag to create."
- Change the form element description: "The type of entities on which this flag will be used. This cannot be changed once the flag is created."
Remaining tasks
Create patch.
User interface changes
The text on the flag add page would change.
API changes
None.
Data model changes
None.
| Comment | File | Size | Author |
|---|---|---|---|
| #12 | duplicate_cannot_be-2834635-11.patch | 851 bytes | gfcamilo |
| #8 | duplicate_cannot_be_changed_message-2834635-8.patch | 547 bytes | shubhang |
Comments
Comment #2
joachim commentedI would suggest keeping the warning about changing on the actual form element, and leave the overall description as just:
> Select the type of flag to create.
Comment #3
socketwench commentedComment #4
joachim commentedBTW, it was in #2815095: Add description to Scope field to explain it will be / why it is disabled, not the issue about tempstore.
EDIT: Not even that; that was about the scope field.
Git blame shows this line was added in
Comment #5
shubhang commentedI have changed the following:
1. Text at top of the form to "Select the type of flag to create."
2. form element description to "The type of entities on which this flag will be used. This cannot be changed once the flag is created."
I am a beginer, so if i do any mistakes please let me know.
Comment #6
joachim commentedThanks for the patch! It's always nice to see newcomers have go at making a patch :)
Looks good apart from one thing:
Drupal core avoids the term 'entities' in the UI. Leave this as is please.
Also, remember to set an issue to 'needs review' when you upload a patch ;)
Comment #7
shubhang commentedShould i change the form descrition to "Type of item to reference. This cannot be changes once the flag is created." ?
Comment #8
shubhang commentedI have changed the following:
1. Text at top of the form to "Select the type of flag to create."
While the description remains the same as it was earlier.
Comment #9
shubhang commentedComment #11
gfcamilo commentedComment #12
gfcamilo commentedI have changed the following:
1. Text at top of the form to "Select the type of flag to create."
Comment #13
gfcamilo commentedComment #14
gfcamilo commentedComment #15
socketwench commentedLooks good to me!
Comment #17
joachim commentedCommitted.
Thanks everyone!