Support for Drupal 7 is ending on 5 January 2025—it’s time to migrate to Drupal 10! Learn about the many benefits of Drupal 10 and find migration tools in our resource center.Problem/Motivation
Views which use the flag_relationship plugin need to depend on the flag that is used by the relationship.
Proposed resolution
Change relationship plugin to add the dependency.
Remaining tasks
Create patch.
User interface changes
N/A.
API changes
N/A.
Data model changes
Views which use the flag relationship plugin have a new dependency.
| Comment | File | Size | Author |
|---|---|---|---|
| #21 | 2757395-21.patch | 7.75 KB | alexpott |
| #16 | 2757395-16.patch | 1.67 KB | alexpott |
| #11 | brokenFlag82_2757395.11.patch | 611 bytes | socketwench |
Comments
Comment #2
socketwench CreditAttribution: socketwench at FFW commentedStarting with a rollback of the last known good branch version.
Comment #5
socketwench CreditAttribution: socketwench at FFW commentedOkay, that at least confirms that it wasn't Flag changes that broke the module. Something in core testing changed.
Comment #6
socketwench CreditAttribution: socketwench at FFW commentedRegenerating the bookmark flag to see what happens...
Comment #9
BerdirAre you using the latest 8.2.x version locally? I can reproduce them.
AdminUiTest Fails because of #2753055: Change "Save order" to "Save". You can just switch to Save but then it will fail in 8.1. You could detect which string is on the page and then use that dynamically to make it work with both.
Not sure about bookmark, maybe ask @dawehner about that one.
Comment #10
socketwench CreditAttribution: socketwench at FFW commentedMe either. I regenerated the view yml on the most recent version of core, but it still fails with a similar error.
Comment #11
socketwench CreditAttribution: socketwench at FFW commentedFix for the AdminUI failure.
Comment #14
socketwench CreditAttribution: socketwench at FFW commentedThis issue appears to have broken flag: #2754477: Unexpected config entity delete due to dependency calculations
Works before that commit, broken after.
Comment #15
jonathan1055 CreditAttribution: jonathan1055 as a volunteer commentedHi,
In Scheduler module we had a similar thing where our previously fully-passing codebase on 24th June started failing in 8.2. #2757625: Previously passing tests now fail in Drupal 8.2 - Change assertRaw to assertText has the details.
In our case the cause was core issue #2513402: Any time a user creates a thing and saves, display a link to the thing created in the status. which was committed on 25th June.
Jonathan
Comment #16
alexpottThe problem is that the order in which things are installed is not guaranteed when the config system can;t work out the dependencies. Views which use the flag_relationship plugin need to depend on the flag they are using.
Comment #17
alexpottThe patch in #16 also makes flag_bookmark re-installable because the config it provides now depends on it using the enforced dependency.
Comment #18
alexpottThis patch needs to add tests to ensure the dependency is added. It also needs to re-export all the views it creates - and it should provide post update function that updates existing views that use the flag_relationship plugin.
Comment #21
alexpottThe fails happening in #16 are happening because of #2758395: Flag 8.x HEAD is broken because 'save order' has changed to 'save'
Patch attached adds missing dependencies and tests the two feature modules provided by flag to ensure they can be reinstalled and what they create has the expected dependencies.
It would be nice to add tests for:
Comment #24
socketwench CreditAttribution: socketwench at FFW commentedNow that #2758395: Flag 8.x HEAD is broken because 'save order' has changed to 'save' is in, let's retest.
Comment #26
socketwench CreditAttribution: socketwench at FFW commentedThank you Alex and everyone! HEAD is fixed again!