Add a test to ensure that views data cache is cleared when flag added/deleted [#2629180]

To reproduce:

- start with a site with no user flags (such as on initial install of Flag)
- add a view of users
- notice there is no 'user flag' relationship, because there are no user flags yet
- add a user flag
- go back to the view and add a relationship: there is still no 'user flag' relationship, even though there is a user flag now.
- clear caches
- user flag relationship is now visible

Adding or deleting a flag should therefore clear Views data caches. For bonus points, only clear them when we're adding a flag of a type that doesn't exist yet / deleting the last flag of its type.

Comment	File	Size	Author
#12	2926180-12.patch	1.93 KB	arunkumark
#12	8.x-4.x: PHP 7 & MySQL 5.5, D8.5.1 PHPLint Failed
#5	interdiff-2-5.txt	509 bytes	zahord
#5	2926180-5.patch	1.51 KB	zahord
#5	8.x-4.x: PHP 7 & MySQL 5.5, D8.5.1 PHPLint Failed PHP 7 & MySQL 5.5, D8.4 79 pass, 2 fail PHP 7 & MySQL 5.5, D8.4 79 pass, 2 fail PHP 5.5 & MySQL 5.5, D8.5.1 PHPLint Failed
#2	2629180-2.patch	1 KB	zahord
#2	8.x-4.x: PHP 7 & MySQL 5.5, D8.6 20 pass, 36 fail

Support from Acquia helps fund testing for Drupal Acquia logo

Comments

Comment #1

4 December 2015 at 21:17

joachim created an issue. See original summary.

Comment #2

zahord CreditAttribution: zahord as a volunteer and at Skilld commented 18 January 2018 at 16:23

File	Size
2629180-2.patch	1 KB
8.x-4.x: PHP 7 & MySQL 5.5, D8.6 20 pass, 36 fail

Comment #3

zahord CreditAttribution: zahord as a volunteer and at Skilld commented 18 January 2018 at 16:23

Status:

Active

» Needs review

Comment #4

18 January 2018 at 16:28

Status:

Needs review

» Needs work

The last submitted patch, 2: 2629180-2.patch, failed testing. View results
- codesniffer_fixes.patch Interdiff of automated coding standards fixes only.

Comment #5

zahord CreditAttribution: zahord as a volunteer and at Skilld commented 24 January 2018 at 13:27

File	Size
2926180-5.patch	1.51 KB
8.x-4.x: PHP 7 & MySQL 5.5, D8.5.1 PHPLint Failed PHP 7 & MySQL 5.5, D8.4 79 pass, 2 fail PHP 7 & MySQL 5.5, D8.4 79 pass, 2 fail PHP 5.5 & MySQL 5.5, D8.5.1 PHPLint Failed
interdiff-2-5.txt	509 bytes

updated

Comment #6

zahord CreditAttribution: zahord as a volunteer and at Skilld commented 24 January 2018 at 13:28

Status:

Needs work

» Needs review

Comment #7

24 January 2018 at 13:32

Status:

Needs review

» Needs work

The last submitted patch, 5: 2926180-5.patch, failed testing. View results
- codesniffer_fixes.patch Interdiff of automated coding standards fixes only.

Comment #8

socketwench CreditAttribution: socketwench as a volunteer commented 25 February 2018 at 20:50

There is an older patch for this which contains the fixes for the Flag entity: https://www.drupal.org/project/flag/issues/2851054#comment-12412982

+++ b/tests/src/FunctionalJavascript/FlagContextualLinksTest.php
@@ -157,6 +157,7 @@ public function setUp() {
+    $this->container->get('views.views_data')->clear();

I'm still concerned about this line, though. Why are we clearing the views cache in a test?

Comment #9

andypost

he/him

Russian

CreditAttribution: andypost as a volunteer and at Skilld commented 25 February 2018 at 21:54

Issue tags:

+Needs tests, +Needs reroll

3 files were hidden/shown/deleted

File	Size
2629180-2.patch	1 KB
8.x-4.x: PHP 7 & MySQL 5.5, D8.6 20 pass, 36 fail
2926180-5.patch	1.51 KB
8.x-4.x: PHP 7 & MySQL 5.5, D8.5.1 PHPLint Failed PHP 7 & MySQL 5.5, D8.4 79 pass, 2 fail PHP 7 & MySQL 5.5, D8.4 79 pass, 2 fail PHP 5.5 & MySQL 5.5, D8.5.1 PHPLint Failed
interdiff-2-5.txt	509 bytes

This issue should be focused on adding tests cos I failed to write ajax tests for views relation in #2851054-12: Cannot add Flags relationship to views. Getting AJAX error

+++ b/tests/src/FunctionalJavascript/FlagContextualLinksTest.php
@@ -157,6 +157,7 @@ public function setUp() {
+    $this->container->get('views.views_data')->clear();

this no longer needed cos flags do clear cache on save/delete now

Comment #10

andypost

he/him

Russian

CreditAttribution: andypost as a volunteer and at Skilld commented 25 February 2018 at 21:57

Title:

adding a flag should clear the Views data cache

» adding a test that makes sure cache cleared when flag added deleted

case for test still valid in IS

Comment #11

socketwench CreditAttribution: socketwench as a volunteer commented 2 April 2018 at 14:45

Priority:

Normal

» Critical

Bumping status since this is holding up other views improvements.

Comment #12

arunkumark

Coimbatore

CreditAttribution: arunkumark as a volunteer and at DrupalPartners for CodeExpertz commented 3 April 2018 at 15:14

Status:

Needs work

» Needs review

File	Size
2926180-12.patch	1.93 KB
8.x-4.x: PHP 7 & MySQL 5.5, D8.5.1 PHPLint Failed

I have re-rolled the patch to resolve the issue with the suggestion from the comment #10

Comment #13

3 April 2018 at 17:07

Status:

Needs review

» Needs work

The last submitted patch, 12: 2926180-12.patch, failed testing. View results

Comment #14

socketwench CreditAttribution: socketwench as a volunteer commented 3 April 2018 at 17:23

1 file was hidden/shown/deleted

File	Size
2926180-12.patch	1.93 KB
8.x-4.x: PHP 7 & MySQL 5.5, D8.5.1 PHPLint Failed

Thanks for the patch @arunkumark, but the postSave() and postDelete() are already part of the Flag entity.

@andypost Do we still need the views clears in the tests?

Comment #15

andypost

he/him

Russian

CreditAttribution: andypost as a volunteer and at Skilld commented 4 April 2018 at 02:05

If was commited as I remember, here we should add a test and remove manual cleaning from otger tests

Comment #16

andypost

he/him

Russian

CreditAttribution: andypost as a volunteer and at Skilld commented 4 April 2018 at 02:09

Yes, cache clear in https://cgit.drupalcode.org/flag/tree/src/Entity/Flag.php?h=8.x-4.x#n503

Comment #17

Berdir

German

Switzerland

CreditAttribution: Berdir at MD Systems GmbH commented 29 October 2019 at 20:56

Title:	adding a test that makes sure cache cleared when flag added deleted	» Add a test to ensure that views data cache is cleared when flag added/deleted
Category:	Bug report	» Task
Priority:	Critical	» Normal
Issue tags:	-Needs tests

That sounds like a normal task and not a critical bug then now? Also can't find any manual views data cache clears in test, being able to remove those would have been easy test coverage.