Support for Drupal 7 is ending on 5 January 2025—it’s time to migrate to Drupal 10! Learn about the many benefits of Drupal 10 and find migration tools in our resource center.Rules condition "Flag threshold" should be ported to 8.x...
| Comment | File | Size | Author |
|---|---|---|---|
| #1 | flag-threshold-rules-condition-2540038-1.patch | 6.37 KB | djevans |
| |||
Issue fork flag-2540038
Show commands
Start within a Git clone of the project using the version control instructions.
Or, if you do not have SSH keys set up on git.drupalcode.org:
compare
Comments
Comment #1
djevans CreditAttribution: djevans as a volunteer commentedHere's my first attempt.
The class
\Drupal\flag\Plugin\Derivative\FlagThresholdDerivergenerates plugin derivatives for each flag type.Comment #2
djevans CreditAttribution: djevans as a volunteer commentedComment #3
djevans CreditAttribution: djevans as a volunteer commentedComment #4
socketwench CreditAttribution: socketwench at FFW commentedI admit, I don't know much about Rules programming at all. How would we go about adding tests for this?
Comment #5
TR CreditAttribution: TR commented@djevans: Are you still working on this? It's still assigned to you, as are a number of other issues listed in #2424465: [Meta] Implement Rules 8.x Support.
Core Rules has PHPUnit tests for the conditions that are defined as part of core Rules. These tests can be used as examples for tests of Flag conditions.
Comment #6
TR CreditAttribution: TR commentedI guess djevans is not working on this anymore.
Comment #8
TR CreditAttribution: TR commented@holybiber: What's that supposed to be?
Comment #9
holybiber@TR I just created the issue fork to try out drupalpod, didn't write any code. I thought this isn't visible to anyone until I actually create a commit, sorry.
I have intentions to work on this though, using the new ECA module.
Comment #10
TR CreditAttribution: TR commented@holybiber: The holdup is that the maintainers of Flag haven't committed any of the patches for Rules support - it's been 6 years for this issue alone. You really think that starting a new module to do the same thing as Rules will be a solution to your needs? How about contributing to support all the work the community has done over the past 6 years to try to port the Rules support in the Flag module from D7 to D8/D9? Frankly, this all should have been done 6 years ago. If you think it will be faster to start from scratch, you're delusional. All you would be doing is diluting the work that's already been done and making it HARDER to reach the goal.
Comment #11
holybiber@TR: I'm not the one doing the ECA module, I just heard about it some weeks ago and on the DrupalCon Europe I had the chance to talk to those who are developing it. There is a whole group behind it, making good progress. They talked also to those who are/were trying to port the Rules module to D8 - it's not really looking like this will happen as far as I've heard.
So I'm just here as someone who needs the threshold functionality, evaluating on what's a good and future-proof way to do so and becoming more convinced that implementing it with the new ECA module is a good idea and wouldn't require much effort. I don't want to frustrate anyone else, sorry if I did.