use states rather than validation to allow link type options to be required [#2053469]

The options for the 'confirm form' flag link type are technically required, in that leaving them blank and submitting the form makes the form fail submission.

However, they are not marked as #required in the form array, so the user doesn't know they were required until they see the error message.

The reason for this is that they are hidden, and only shown if you pick the link type they go with. So making them #required would mean that they'd be required even when hidden and irrelevant -- which would be a huge UI bug!

But now on D7 we can achieve this with states: we already toggle visibility based on the link type checkbox; we can do the same with the 'required' property.

Comment	File	Size	Author
#1	2053469.flag_.link-type-options-required.patch	2.99 KB	joachim
#1

Support from Acquia helps fund testing for Drupal Acquia logo

Comments

Comment #1

joachim CreditAttribution: joachim commented 30 July 2013 at 07:06

Status:

Active

» Needs review

File	Size
2053469.flag_.link-type-options-required.patch	2.99 KB

Comment #2

socketwench CreditAttribution: socketwench commented 3 October 2013 at 02:15

+++ b/includes/flag.admin.inc
@@ -536,6 +538,8 @@ function flag_form($form, &$form_state, $flag) {
+    // This will get change to a state by flag_link_type_options_states().

Shouldn't that be "changed"? Otherwise, looks good. Confirmed by manual testing.