Such as flag_page(), flag_confirm(), and submit handlers.

Needs checking that the JS callbacks work ok with this, but AFAIK they should be fine.

CommentFileSizeAuthor
#5 move_menu_callbacks_to_flag_pages_inc-1698994-5.patch10.35 KBScyther
#2 move_menu_callbacks_to_flag_pages_inc-1698994-2.patch10.42 KBScyther
Support from Acquia helps fund testing for Drupal Acquia logo

Comments

joachim’s picture

joachim CreditAttribution: joachim commented
Version: 7.x-2.x-dev » 7.x-3.x-dev
Scyther’s picture

Scyther CreditAttribution: Scyther commented
Status: Active » Needs review
FileSize
move_menu_callbacks_to_flag_pages_inc-1698994-2.patch10.42 KB

Here is a patch with the menu callbacks move to seperate file. I have tested it and it should work.

joachim’s picture

joachim CreditAttribution: joachim commented

Thanks for the patch!

I'm afraid though that I'm pretty sure this will be broken by the massive changes over at #1681540: replace 'content' with 'entity', eg $content_type with $entity_type. I maybe should have marked 3.x issues postponed in the meantime, sorry.

Scyther’s picture

Scyther CreditAttribution: Scyther commented

No problem, let me know when that is done and I can make a new patch!

Scyther’s picture

Scyther CreditAttribution: Scyther commented
FileSize
move_menu_callbacks_to_flag_pages_inc-1698994-5.patch10.35 KB

Update patch to work with the new commits from #1681540: replace 'content' with 'entity', eg $content_type with $entity_type

joachim’s picture

joachim CreditAttribution: joachim commented
Status: Needs review » Fixed

That's perfect. Thanks!

Issue #1698994 by Scyther: Moved menu callbacks to a flag.pages.inc file.

Status: Fixed » Closed (fixed)

Automatically closed -- issue fixed for 2 weeks with no activity.