make use of machine name field in admin UI

Patch:
- Moves the title field to the first add flag form and changes the name field to machine-name type.
- When going from the first form page to the second one, when adding a new flag, the flag is stored temp in a cache table with ctools. (Taken insperation from Views)
- Adds dependencies for ctools for using the cache meantion above.
- Not allowed to change the name (machine-name) after the flag is saved. Good or bad?!?!
- The url for the second form when adding flag has been changed from admin/structure/flags/add/*type*/*name* to admin/structure/flags/add/*name* because the type is not longer needed because it is saved in the temporary cached flag.

There is things that could be improved and I will try to get time to work on thoose and make a new patch. Please give some feedback.

New patch with updated DrupalWebTestCase.

Here is a new patch without the dependency for CTools.

I'm wondering whether the approach ought to be to take the name field off the type selection form entirely, and have a menu callback for the flag add form that takes a type argument. Would need some path tweaking:

- '/manage/%flag/edit' edits a named, existing flag
- 'add/TYPE' would need to present the edit form but for a new, empty flag.

Sounds good, will take a look a this and make a new patch.

Patch with thoose changes you proposed.

Patches that I have made so far, you can't change the name (machine name) of the flag after it's saved. Good or bad?

+++ b/includes/flag.admin.incundefined
@@ -289,7 +262,22 @@ function flag_form($form, &$form_state, $flag) {
+    '#title' => t('Flag name'),

Personally, I find "Flag name" confusing for the #title. I'd rather it read "Machine name". What does View's do?

EDIT: I'm also concerned that this patch would blow up when #1681540: replace 'content' with 'entity', eg $content_type with $entity_type gets in.

> Personally, I find "Flag name" confusing for the #title. I'd rather it read "Machine name".

Fixed

> IIRC we currently allow changing of the machine name, with caveats. So I'd say we should keep that functionality.

Fixed

+++ b/includes/flag.admin.inc
@@ -247,17 +238,14 @@ function flag_add_form($form, &$form_state) {
-  $errors = $flag->validate_name();
-  foreach ($errors as $field => $field_errors) {
-    foreach ($field_errors as $error) {
-      form_set_error($field, $error['message']);
-    }

> This needs to move to the flag edit form.
Does it? Machine name field has it own validation and does it same as $flag->validate_name() does. See form_validate_machine_name()
Also in in flag_form_validate(), $flag->validate() is called which calls $this->validate_name().

Looks good to me.

And committed. http://drupalcode.org/project/flag.git/commit/2127cdd

No problem. I will update my patch as soon as the "monster patch" is applied :)

My fault, should have realized that would happen. >_<

Update patch to work with the new commits from #1681540: replace 'content' with 'entity', eg $content_type with $entity_type

Patch updated.

- 'Select flag type' title on the first add page.
- 'Add new @type flag' title on the second add page.
- Changed title for the action link for adding new flag, from 'Add a new flag' to 'Add flag'.
- Changed value for the submit button on the first add page from 'Add flag' to 'Continue'.

And here is the patch