To help fivestar work with jQuery 1.3.2 in jQuery Update can we please remove the @ in the selectors. It was depreciated as of 1.2 and removed in 1.3. Change highlighted below.

jQuery 1.2.x:

$("a[@href*='admin/build/testing']").doSomething();

jQuery 1.2.6 and 1.3.x:

$("a[href*='admin/build/testing']").doSomething();

More detail at http://docs.jquery.com/Selectors/attributeHas#attribute

CommentFileSizeAuthor
#1 fivestar_attribute_selector.patch1.35 KBquicksketch
Support from Acquia helps fund testing for Drupal Acquia logo

Comments

quicksketch’s picture

quicksketch
he/him
CreditAttribution: quicksketch commented
Status: Active » Fixed
FileSize
fivestar_attribute_selector.patch1.35 KB

Thanks, I don't know what those "@" symbols are still doing in Fivestar, I meant to remove them in the Drupal 6 upgrade. Fixed with the attached patch, committed.

Status: Fixed » Closed (fixed)

Automatically closed -- issue fixed for 2 weeks with no activity.

dddave’s picture

dddave CreditAttribution: dddave commented

Does "commited" mean a new release of fivestar should be out? A couple of weeks lies behind us, is there a specific reason for the delay or am I misunderstanding something here?