Comments with ratings have clickable ratings for other users [#2919915]

If a comment is entered with a rating, any user can view that comment once it's published and the stars give the impression that they can be changed since their styling indicates it and if the user clicks on a different star the rating appears to stick to that newly selected star for the duration of the current page load.

Comment	File	Size	Author
#5	comments_with_ratings-4.patch	1022 bytes	Mitriy-Bug
#5
#4	v29NEOWh3yqMZA.png	74.57 KB	Mitriy-Bug
#3	comments_with_ratings-2919915-3.patch	910 bytes	cbildstein
#3
#2	comments_with_ratings-2919915-2.patch	919 bytes	swickham
#2

Support from Acquia helps fund testing for Drupal Acquia logo

Comments

Comment #1

31 October 2017 at 06:27

swickham created an issue. See original summary.

Comment #2

swickham CreditAttribution: swickham at Acro Commerce commented 31 October 2017 at 06:29

Status:

Active

» Needs review

File	Size
comments_with_ratings-2919915-2.patch	919 bytes

I didn't spend much time to make sure this was the best way to go about it, but here's a patch that checks to see if the element being created has a value already selected, only the ones with no value selected create stars with the tag that seems to be causing the confusion.

Comment #3

cbildstein CreditAttribution: cbildstein at Acro Commerce commented 21 November 2017 at 15:56

File	Size
comments_with_ratings-2919915-3.patch	910 bytes

Tried out the #2 patch but ran into issues in cases where you set a default rating value and the widget would never work in the form because of this check:

if ($select.val() === '-') {

I updated it to check for the form value instead, so the widget would only display when within an actual form where you would need the widget.

if (element.form) {

Seemed to work in my use cases but should be further tested.

Comment #4

Mitriy-Bug CreditAttribution: Mitriy-Bug commented 30 November 2017 at 06:17

File	Size
v29NEOWh3yqMZA.png	74.57 KB

But then all the stars are grey and not clear what the rating

Comment #5

Mitriy-Bug CreditAttribution: Mitriy-Bug commented 30 November 2017 at 06:45

File	Size
comments_with_ratings-4.patch	1022 bytes

Made, check. You only need the styles to correct

<style>
div.fivestar-widget .star span {
  display: block;
  width: 100%;
  height: 100%;
  background-position: 0 0; /* RTL */
  cursor: pointer;
}
div.fivestar-widget div.on span {
  background-position: 0 -16px; /* RTL */
}
.fivestar-oxygen div.fivestar-widget .star span {
  background-image: url(star.png);
}
</style>

Comment #6

sorabh.v6

He/His

Hindi

CreditAttribution: sorabh.v6 at Acro Commerce commented 14 December 2017 at 10:50

Status:

Needs review

» Needs work

None of the patches are working for me. I am using dev-1.x and "reference": "ee888670ec12". I created the rating from the admin account and I am able to change the rating stars as an anonymous user. Though they get reset when I refresh the page.