Support for Drupal 7 is ending on 5 January 2025—it’s time to migrate to Drupal 10! Learn about the many benefits of Drupal 10 and find migration tools in our resource center.
Fivestars show the plain version and the java version in the same time when shown in thickbox.
In IE and Safari it is OK, the problem is only in Firefox.
what can it be?
you can see it at www.iamblessed.org
click on the baloon at the upper left corner of the screen ("3 random PT's").
Comments
Comment #1
quicksketchI can't access your test site. Do you have another place to have a look or additional information that might help lead to the problem?
Comment #2
itaye CreditAttribution: itaye commentedPlease try again now.
thanks
Comment #3
quicksketchNeat site. I unfortunately couldn't reproduce with Firefox 2.0.0.12 (Mac OS X). What version of Firefox are you using (any plugins also)? Do you get javascript errors on the page?
Comment #4
itaye CreditAttribution: itaye commentedthanks.
i am not a programmer so will try to give you any information you need, but if you will need more just tell me how i can check it.
i am using Mozilla/5.0 (Windows; U; Windows NT 5.1; en-US; rv:1.8.1.12) Gecko/20080201 Firefox/2.0.0.12,
and i have no javascripts errors.
Comment #5
mooffie CreditAttribution: mooffie commentedItay,
It seems fivestar doesn't completely work in a thickbox. But do other pages, that use javascript, work in a thickbox?
In other words:
Open, e.g., 'node/add/whatever' in a thickbox and see if you can open/close the collapsed fieldsets in it (in Firefox).
Comment #6
quicksketchClosing after lack of activity.
Comment #7
mooffie CreditAttribution: mooffie commentedYes, this issue should be closed.
But I'm marking it "won't fix" instead.
I was able to reproduce the problem on my computer. There are actually several JS problems here, but after some investigation I concluded that these problems have little to do with Fivestar itself (These problems could be seen with almost any other page that uses jQuery) .
But there is actually one JS problem, not reported in this issue, that is indeed Fivestar's fault. I opened an offshoot issue to address it: #246804: javascript: 'class guard' + behavior
Comment #8
jun CreditAttribution: jun commentedI found a fix for this, it involves modifying thickbox itself so that, instead of dropping the html inside the thickbox, it appends it, which keeps the various initializations (particularly the event handlers) that fivestar does.
I'll submit the patch to Cody Lindley the Thickbox developper, but in the meantime here is what I've done (which might not work if there's just plaintext inside the div with the inlineId class) :
in modules/thickbox/thickbox.js
line 211 replace
$("#TB_ajaxContent").html($('#' + params['inlineId']).html());
by
$("#TB_ajaxContent").append($('#' + params['inlineId']).children().attr("inlineId",params['inlineId']));
and then line 261 (after $("#TB_closeWindowButton").unbind("click");) add the following :
inlineId = $("#TB_ajaxContent").children().attr("inlineId");
$("#TB_ajaxContent").children().removeAttr("inlineId");
$('#' + inlineId).append($("#TB_ajaxContent").children());
I'll post about this fix in the thickbox issues as well.
Hope this helps,
Jun.