User error: Invalid placeholder (!github) in string: The Fitvids module uses the FitVids.js jQuery plugin to achieve fluid/responsive video embeds. You don't need it for pure HTML5 videos. in Drupal\Component\Render\FormattableMarkup::placeholderFormat() (line 233 of core/lib/Drupal/Component/Render/FormattableMarkup.php).

Drupal\Component\Render\FormattableMarkup::placeholderFormat('The Fitvids module uses <a href="!github" rel="external">the FitVids.js jQuery plugin</a> to achieve fluid/responsive video embeds. You don't need it for pure HTML5 videos.', Array) (Line: 204)
CommentFileSizeAuthor
#3 2726435-3.patch4.47 KBchegor
Support from Acquia helps fund testing for Drupal Acquia logo

Comments

chegor created an issue. See original summary.

chegor’s picture

chegor CreditAttribution: chegor as a volunteer commented
Issue summary: View changes
chegor’s picture

chegor CreditAttribution: chegor as a volunteer commented
Status: Active » Needs review
FileSize
2726435-3.patch4.47 KB

patch attached

DerekAhmedzai’s picture

DerekAhmedzai CreditAttribution: DerekAhmedzai commented

I've included this a new dev release, thanks for the patch.

chegor’s picture

chegor CreditAttribution: chegor as a volunteer commented

I hope you will add me as a author of git commit.

  • DerekAhmedzai committed 2879849 on 8.x-1.x authored by chegor 
    Issue #2726435 by chegor: User error: Invalid placeholder (!github),...
DerekAhmedzai’s picture

DerekAhmedzai CreditAttribution: DerekAhmedzai commented

Yes I've modified the commit message to credit you

DerekAhmedzai’s picture

DerekAhmedzai CreditAttribution: DerekAhmedzai commented
Status: Needs review » Fixed

Status: Fixed » Closed (fixed)

Automatically closed - issue fixed for 2 weeks with no activity.