Transliteration is not working on the File attach source

I applied the 'filefield_source-change_language_list-2876161-2-8x.patch' patch and used the command

find . -type f \( -name '*.inc' -or -name '*.php' -or -name '*.module' \) -exec grep --color=auto language_list {} \+

I did not find any other 'language_list' occurrences.

So the patch worked for me.

It seems that the transliteration_clean_filename() does not exists either in D8.

mmm, this makes me wonder if this function it's used at all. 🤔

I'm going to check before to commit this.

Thanks for your patch.

Yup, the whole function is not working, I'm going to work on this.

Patch attached.

We need a test with a file with special characters so we can prove that the transliteration is working, so this needs work.

Ok I was finally able to work on this.

I refactored a bit the tests and include one that tests a file with special characters.

Patch attached.