Wrong file name when transliteration is applied to file paths / new files deleted.

Ok, this is actually worst. Critical. Though, I was afraid to report it like this because I could not believe it was happening.

Slashes are removed from the file path in filefield_paths_process_file(), this line:

  $file['filepath']['new'] = filefield_paths_process_string($file['filepath']['new'], 'field', array(0 => $file['field']), $settings['filepath']);

For example, if $file['filepath']['new'] = 'sites/example.com/files/test.txt', it ends up as 'sitesexample.comfilestest.txt'.

Then, the following code is executed:

  // Finalize files if necessary
  if (dirname($file['filepath']['new']) != dirname($file['field']['filepath']) || $file['filename']['new'] != $file['field']['filename']) {
    if (filefield_paths_file_move($file)) {

Where dirname($file['filepath']['new']) is '.', and dirname($file['field']['filepath']) is 'sites/example.com/files', so the IF condition is TRUE, then filefield_paths_file_move($file) is evaluated, and here we have the following code:

  $dest = _filefield_paths_strip_path(dirname($file['filepath']['new'])); // equals to $dest = '.';
  ...
  ...
  if (!file_move($file['field']['filepath'], $dest .'/'. $file['filename']['new'], $replace)) {

That is equal to file_move('sites/example.com/files/test.txt', './test.txt', TRUE). Looking at file_move() in drupal's include/file.inc we have:

function file_move(&$source, $dest = 0, $replace = FILE_EXISTS_RENAME) {
  $path_original = is_object($source) ? $source->filepath : $source;

  if (file_copy($source, $dest, $replace)) {
    $path_current = is_object($source) ? $source->filepath : $source;

    if ($path_original == $path_current || file_delete($path_original)) {
      return 1;
    }
    drupal_set_message(t('The removal of the original file %file has failed.', array('%file' => $path_original)), 'error');
  }
  return 0;
}

First the file is copied to destination, then if original and destination paths are not equal, the file removed. Seems good, but it isn't, because the same file that's copied here, is then removed. We can see this by looking at file_copy(), where the first line of code does this:

  $dest = file_create_path($dest); // file_create_path('./test.txt') = 'sites/darwin.cvs.gamefilia.com/files/./test.txt'

So destination really points to the same source file, that's first copied and then removed in file_move().

Solution to this might involve a patch to drupal core, but in the meantime, maybe filefield_paths could normalize the source and destination paths before running a file_move().

That being said, I solved my issue with the patch in the issue starter, but I believe something else should be done to ensure files are not removed when other configurations generate a destination file path without subdirectories, which is when dirname($file) will return '.'.

For reference, I have created a bug report to Drupal core: #398874: file_move('sites/example.com/files/test.txt', './test.txt') removes destination file!

Nope, the filename is just 'test.txt'.

In filefield settings I have the following:

- Path settings / File path: empty
- Path settings / File path cleanup settings / Transliterate: enabled

When File Path is empty, filefield places the file in the site files directory, and the filepath looks like that, which is what then filefield_paths tries to transform causing this problem I mentioned.

PS: I known how to create a patch, but I think it is a bit more complex, so you may have to try and test for yourself. My first aim was to describe the problem the best I could, not just give you a patch.

Sorry, reverting the issue status.

Wow, thanks for the super quick response. I'll try to test the fixes later today.

it just seemed odd that you would be transliterating an empty field

Yes, it's confusing, but I noticed this happens against the filepath where the file is originally uploaded by filefield, so it is the files directory of the site. ie. something like files/test.txt, sites/all/files/test.txt, sites/example.com/files/test.txt, etc.

filefield_pahts starts to transform the filepath from that, from where filefield uploaded the file, not before filefield computes the detiation of the file, so filefield_paths computes the new location and performs a move operation.