Fatal error: Call to undefined method Drupal\file\Plugin\Field\FieldType\FileFieldItemList::getThirdPartySettings() in filefield_paths/filefield_paths.module on line 353 [#2662420]

On filefield_paths_entity_update(), when saving a media_entity entity.

Comment	File	Size	Author
#22	filefield_paths-ignore_base_fields-2662420-22.patch	2.46 KB	wil2091
#22
#18	filefield_paths-ignore_base_fields-2662420-15.patch	2.48 KB	JFeltkamp
#18
#14	filefield_paths-ignore_base_fields-2662420-14.patch	1.1 KB	dabblela
#14
#5	filefield_paths-ignore_base_fields-2662420-5.patch	1.67 KB	jonhattan
#5	8.x-1.x: PHP 5.5 & MySQL 5.5, D8.1 Patch failed to apply PHP 5.5 & PostgreSQL 9.1, D8.1 Patch failed to apply PHP 5.5 & SQLite 3.8, D8.1 Patch failed to apply PHP 5.6 & MySQL 5.5, D8.1 Patch failed to apply PHP 7 & MySQL 5.5, D8.1 Patch failed to apply PHP 7 & PostgreSQL 9.1, D8.1 Patch failed to apply PHP 7 & SQLite 3.14, D8.1 Patch failed to apply
#2	filefield_paths-ignore_base_fields-2662420-1.patch	1.65 KB	jonhattan
#2	8.x-1.x: PHP 5.5 & MySQL 5.5, D8.1 Patch failed to apply PHP 5.5 & PostgreSQL 9.1, D8.1 CI error PHP 5.5 & SQLite 3.8, D8.1 Patch failed to apply PHP 5.6 & MySQL 5.5, D8.1 Patch failed to apply PHP 7 & MySQL 5.5, D8.1 Patch failed to apply PHP 7 & PostgreSQL 9.1, D8.1 Patch failed to apply PHP 7 & SQLite 3.14, D8.1 Patch failed to apply

Support from Acquia helps fund testing for Drupal Acquia logo

Comments

Comment #1

4 February 2016 at 09:42

jonhattan created an issue. See original summary.

Comment #2

jonhattan

Spanish

Plasencia

CreditAttribution: jonhattan as a volunteer commented 4 February 2016 at 11:15

Issue summary:	View changes
Status:	Active	» Needs review

File	Size
filefield_paths-ignore_base_fields-2662420-1.patch	1.65 KB
8.x-1.x: PHP 5.5 & MySQL 5.5, D8.1 Patch failed to apply PHP 5.5 & PostgreSQL 9.1, D8.1 CI error PHP 5.5 & SQLite 3.8, D8.1 Patch failed to apply PHP 5.6 & MySQL 5.5, D8.1 Patch failed to apply PHP 7 & MySQL 5.5, D8.1 Patch failed to apply PHP 7 & PostgreSQL 9.1, D8.1 Patch failed to apply PHP 7 & SQLite 3.14, D8.1 Patch failed to apply

The error is on a base field (thumbnail) provided by media_entity.

Base fields doesn't have third party settings, we need to ignore them.

Comment #3

Deciphered CreditAttribution: Deciphered at Realityloop commented 4 February 2016 at 22:37

Hi @jonhattan,

Can you give me some reproduction steps? I assume there's another module involved, or custom/development code?

I only ask, as out of the box it doesn't appear that there's a simple way to create a Media Entity and I don't currently have the time to dig into the issue. If you can give me a way to reproduce the issue I can then confirm the patch and get it committed.

Thanks in advance.

Comment #4

jonhattan

Spanish

Plasencia

CreditAttribution: jonhattan as a volunteer commented 5 February 2016 at 09:20

Steps to reproduce:

1. Install a site with media_entity and filefield_paths modules:

cd /tmp
drush qd issue-2662420 media_entity media_entity_image filefield_paths --account-pass=admin --browser --yes

2. Login (admin/admin) and create a media bundle at http://127.0.0.1:8888/admin/structure/media/add (label: Image; Type provider: image)

3. Add a field of type Image to the media bundle: http://127.0.0.1:8888/admin/structure/media/manage/image/fields/add-field. Use all defaults. No need to configure filefield_paths

4. Finally create a media entity http://127.0.0.1:8888/media/add/image and save. Result:

Fatal error: Call to undefined method Drupal\Core\Field\BaseFieldDefinition::getThirdPartySettings() in /tmp/issue-2662420/drupal/modules/filefield_paths/filefield_paths.module on line 347

As stated above, the media entity provides a base field named thumbnail, of type image. Base fields don't have third party settings.

I've hit this problem in custom code several times, and I guess this will be a recurring issue across contrib.

API details:

* All field providers implements https://api.drupal.org/api/drupal/core!lib!Drupal!Core!Field!FieldDefini...

* Fields created in the UI are FieldConfig instances - https://api.drupal.org/api/drupal/core!modules!field!src!Entity!FieldCon...

* FieldConfig ancestors are FieldConfigBase and ConfigEntityBase. At some point they implement ThirdPartySettingsInterface

* OTOH Base fields (properties in D7, as nid,title,created,,) are defined in code and implement https://api.drupal.org/api/drupal/core!lib!Drupal!Core!Field!BaseFieldDe.... ThirdPartySettingsInterface is not implemented.

Comment #5

jonhattan

Spanish

Plasencia

CreditAttribution: jonhattan as a volunteer commented 5 February 2016 at 09:25

File	Size
filefield_paths-ignore_base_fields-2662420-5.patch	1.67 KB
8.x-1.x: PHP 5.5 & MySQL 5.5, D8.1 Patch failed to apply PHP 5.5 & PostgreSQL 9.1, D8.1 Patch failed to apply PHP 5.5 & SQLite 3.8, D8.1 Patch failed to apply PHP 5.6 & MySQL 5.5, D8.1 Patch failed to apply PHP 7 & MySQL 5.5, D8.1 Patch failed to apply PHP 7 & PostgreSQL 9.1, D8.1 Patch failed to apply PHP 7 & SQLite 3.14, D8.1 Patch failed to apply

Now tat I've verbalized it, I've realized that $definition instanceof ThirdPartySettingsInterface is a better test.

Comment #6

3 February 2016 at 18:06

Deciphered committed 43aceed on authored by jonhattan

#2662420 by jonhattan: Fixed issue with Base fields.

Comment #7

Deciphered CreditAttribution: Deciphered commented 5 February 2016 at 22:54

Status:

Needs review

» Fixed

Issue confirmed, thanks for the steps, makes the job of maintaining modules much easier ;)

Patch confirmed and committed.

Comment #8

19 February 2016 at 22:54

Status:

Fixed

» Closed (fixed)

Automatically closed - issue fixed for 2 weeks with no activity.

Comment #9

titouille

French

CreditAttribution: titouille as a volunteer commented 8 July 2016 at 07:46

Hi !

I found the same problem by adding an image field in an entity using baseFieldDefinition::create.

Same test :

if ($definition instanceof Drupal\Core\Config\Entity\ThirdPartySettingsInterface) {...}

must be added in the filefield_paths_field_widget_form_alter function or we are facing the same error.

Comment #10

jonhattan

Spanish

Plasencia

CreditAttribution: jonhattan as a volunteer commented 10 July 2016 at 16:39

@titouille please create a new issue and add the steps to reproduce it

Comment #11

amy.h CreditAttribution: amy.h commented 5 April 2017 at 17:10

This issue still persists with me and I have the most up to date version

Comment #12

kala4ek

Russian

🇷🇺 Novosibirsk

CreditAttribution: kala4ek as a volunteer and at DrupalJedi commented 5 July 2017 at 09:27

Up, issue still reproduced for me too.

Comment #13

kala4ek

Russian

🇷🇺 Novosibirsk

CreditAttribution: kala4ek as a volunteer and at DrupalJedi commented 5 July 2017 at 09:30

Got it, need to use DEV release.
There are no releases after 2015.

Comment #14

dabblela CreditAttribution: dabblela commented 2 August 2017 at 20:52

File	Size
filefield_paths-ignore_base_fields-2662420-14.patch	1.1 KB

Still an issue for me with a base image field attached to an entity (in this case, menu item). Patch attached

Comment #15

mibstar CreditAttribution: mibstar commented 20 October 2017 at 09:53

I had the same error as @jonhattan but in my case it was caused by the https://www.drupal.org/project/consumers/releases/8.x-1.0-beta1 module.

Updating to the dev branch did not solve it, however the patch by @manatwo on https://www.drupal.org/node/2662420#comment-12199452 fixed it for me.

Comment #16

stevieb CreditAttribution: stevieb commented 11 January 2018 at 10:45

Just to confirm the patch in #14 works when used with the dev branch

Comment #17

jptreen CreditAttribution: jptreen commented 14 April 2018 at 19:35

+1 The patch at #14 works when applied to beta1, too. (Drupal 8.5.1)

Comment #18

JFeltkamp

German

Hamburg

CreditAttribution: JFeltkamp commented 25 July 2018 at 09:39

File	Size
filefield_paths-ignore_base_fields-2662420-15.patch	2.48 KB

Same issue from filefield_paths_field_widget_form_alter() returned in filefield_paths_entity_update().
I fixed it with the same check from #14. Now works for me. (Core 8.5.5, filefield_paths 1.0.0-beta1)

Comment #19

dercheffe

he/him

German

Sersheim, Germany

CreditAttribution: dercheffe commented 18 August 2018 at 15:26

Wouldn't it make sense to release this issue in a stable release?

File	Size
filefield_paths-ignore_base_fields-2662420-22.patch	2.46 KB

Re-rolling the patch.

Comment #23

Kgaut CreditAttribution: Kgaut commented 10 July 2020 at 13:17

Last patch from #22 works well with 1.0.0-beta2

Comment #24

jonathanshaw

English

Stroud, UK

CreditAttribution: jonathanshaw commented 29 July 2020 at 14:02

4 files were hidden/shown/deleted

File	Size
filefield_paths-ignore_base_fields-2662420-1.patch	1.65 KB
8.x-1.x: PHP 5.5 & MySQL 5.5, D8.1 Patch failed to apply PHP 5.5 & PostgreSQL 9.1, D8.1 CI error PHP 5.5 & SQLite 3.8, D8.1 Patch failed to apply PHP 5.6 & MySQL 5.5, D8.1 Patch failed to apply PHP 7 & MySQL 5.5, D8.1 Patch failed to apply PHP 7 & PostgreSQL 9.1, D8.1 Patch failed to apply PHP 7 & SQLite 3.14, D8.1 Patch failed to apply
filefield_paths-ignore_base_fields-2662420-14.patch	1.1 KB

filefield_paths-ignore_base_fields-2662420-15.patch	2.48 KB

filefield_paths-ignore_base_fields-2662420-22.patch	2.46 KB

This issue is closed and fixed in #5.

Yes there are other problems with base fields not addressed in #5, but these are being addressed in #2718783: Call to undefined method BaseFieldDefinition::getThirdPartySettings(). Comment on that issue and use patches from that issue, please don't upload patches or comment here.