Retroactive update doesn't update old revisions of nodes [#1115740]

When "Retroactive update" on filefields in nodes with revisions, only the last revision gets updated.

This happens because even if in filefield_filefield_paths_batch_update() retrieves the correct list with nodes, in filefield_paths_batch_update() the list is flatten using array_unique().

Steps to reproduce:
1) Create a file field on a node type, set to public://
2) Attach two fields to the node and save
3) Create a new revision and delete one of the flies, so that the first revision has both, the second only has one.
4) Change the field to private://, check the retroactive update box, and save the field settings
5) Observe in the file_managed table of the database that the file entity that is still attached to the current revision has been converted to private://, however the file entity only attached attached to the first revision, deleted from the second revision, is still public://.

Comment	File	Size	Author
#10	filefield_paths-retroactive_update_doesnt_update_old_revisions_of_nodes-1115740-10.patch	20.88 KB	jaypan

Issue fork filefield_paths-1115740

Show commands

Start within a Git clone of the project using the version control instructions.

Add & fetch this issue fork’s repository

Or, if you do not have SSH keys set up on git.drupalcode.org:

Add & fetch this issue fork’s repository

8.x-1.x changes, plain diff MR !34
Check out this branch for the first time

Check out existing branch, if you already have it locally
1115740-retroactive-update-doesnt compare
Check out this branch for the first time

Check out existing branch, if you already have it locally

About issue forks

Comments

Comment #1

simon georges commented 21 March 2012 at 08:48

Closed #1127456: Retroactive updates doesn't move old revision's files as a duplicate of this one.

Comment #2

deciphered

English

Ballarat, Victoria, Australia

commented 11 August 2015 at 20:36

Issue summary:	View changes
Status:	Active	» Closed (won't fix)

No longer supporting Drupal 6 issues for this module.

Comment #3

j_s commented 9 September 2022 at 00:08

Version:	6.x-1.x-dev	» 7.x-1.x-dev
Status:	Closed (won't fix)	» Active

This issue is still relevant in the Drupal 7 version. In my case, using the retroactive update, files in revisions are not moved. Only the latest version is moved.